Inconsistent editor color in definition list #2893

pinkdroyd posted onGitHub

Current behavior

When I create an definition list that consists of a bullet list, the editor highlights in inconsistently. The first line is highlighted just like text, the next lines like a bullet list. This creates a bit of a chaotic page if you use these lists a lot.

This is what it looks like in the preview (this is fine, just so you know what I am talking about): grafik

This is what it looks like in the editor (all items should be blue, however the first one of each definition is white): grafik

Expected behavior

The first line of the bullet list in a definition should look like the other lines (in my case blue, not white). Like this (this is the coloring of a list): grafik

Environment

Version: 0.11.13

@boostio has funded $20.00 to this issue. See it on IssueHunt

posted by IssueHuntBot about 6 years ago

Can I take this up? Thanks!

posted by ekoeditaa about 6 years ago

Does CodeMirror take care of the highlighting? Or is it done by our own repo? I tracked down the highlighting up till here browser/components/CodeEditor.js

posted by ekoeditaa about 6 years ago

@ekoeditaa yes, CodeMirror take care of the highlighting so this probably an upstream issue. However, Boostnote also has a custom mode here https://github.com/BoostIO/Boostnote/tree/master/extra_scripts/codemirror/mode/bfm

posted by ZeroX-DG about 6 years ago

@ZeroX-DG Seems like the first bullet list is missing cm-variable-2 class. How can I add it dynamically? Can it be done from the bfm grunt task too?

posted by ekoeditaa about 6 years ago

@ekoeditaa Yes, you should do it in the bfm grunt task because the style file will be overridden when the task is executed

posted by ZeroX-DG about 6 years ago

@ZeroX-DG seems like it cannot be done through that. The problem is upstream with CodeMirror. The highlighting doesn't work for indentation from them. We cannot solve it by overriding the css in our custom mode. A possible fix is we let cm-variable-2 color to be the normal black.

posted by ekoeditaa almost 6 years ago

@0maxxam0 has funded $2.00 to this issue.