Minebench/Tresor

Do you want to work on this issue?

You can request for a bounty in order to promote it!

Placeholders #9

Phoenix616 posted onGitHub

Add a provider abstractions for the different placeholder systems.


@phoenix616 has funded $20.00 to this issue.


posted by issuehunt-oss[bot] 11 months ago

The main issue I'm seeing here is the required underscore with PlaceholderAPI but not with MVDW, as well as the PAPI and MVDW formats being different (%name_value% vs {name}). For more specific placeholders ("%island_top_1%") it'd be great to build some kind of context tree. Not sure how fancy I'd like this to be

posted by IllusionTheDev 11 months ago

I don't think the format difference would be a big issue. The basis is the same after all: A key which gets mapped to a value. How that key is replaced and represented internally in the plugins providing the service interface shouldn't really matter for the interface itself. Imo. an interface providing simple key -> value mapping as well as utility methods to replace in strings should be enough. (Although the more I think about text-related stuff I realise that with components being a thing this might get a lot more complicated as we would ideally want component support in the api but not all platforms or plugins use the same ones (Adventure vs. Bungee-Chat vs. other libraries/NMS access). I guess for now a simple string placeholder querying and replacement would be enough and components support could be part of #8, maybe once the ecosystem finally settles on one implementation...)

posted by Phoenix616 11 months ago

Fund this Issue

$20.00
Funded
Only logged in users can fund an issue

Pull requests

Recent activities

eyvallahabi submitted an output to  Minebench/ Tresor# 9
10 months ago
eyvallahabi withdrew the output  to  Minebench/ Tresor# 9
10 months ago