Show error if run on a single file that's ignored #238

OmgImAlexis posted onGitHub

When using xo on a single file no errors are shown if said file is ignored in xo's settings.

➜  agenda git:(master) DEBUG=xo xo test/fixtures/addTests.js 
  xo Using local install of XO. +0ms
➜  agenda git:(master) mv test/fixtures/addTests.js .
➜  agenda git:(master) ✗ DEBUG=xo xo ./addTests.js            
  xo Using local install of XO. +0ms

  addTests.js:1:1
  ✖   1:1   Filename is not in kebab case. Rename it to add-tests.js.     unicorn/filename-case
  ✖   2:3   Strings must use singlequote.                                 quotes
  ✖   2:3   Extra space after key none.                                   key-spacing

Makes sense. Wanna try doing a pull request?

posted by sindresorhus over 7 years ago

On a single file, or all files that is directly called (i.e. not globbed) using the CLI?

posted by kevva over 7 years ago

I would open a PR but I have no clue where to put this type of check.

posted by OmgImAlexis over 7 years ago

@kevva We could do it for all specified non-glob inputs. The only way to really detect whether something is a glob or a direct file reference is to fs.existsSync().

posted by sindresorhus over 7 years ago