xojs/xo

Filter out `.gitignore` patterns before globbing #235

sindresorhus posted onGitHub

See: https://github.com/sindresorhus/xo/pull/204#discussion_r109373003

Doing it after globbing results in a large performance regression when running on large projects, like in #234.


On a really large project it's very inefficient. See: https://github.com/sindresorhus/xo/issues/234#issuecomment-310542486

posted by sindresorhus over 7 years ago

The .gitignore handling moved to https://github.com/sindresorhus/globby, so it needs to be fixed there.

posted by sindresorhus about 6 years ago

@issuehuntfest has funded $80.00 to this issue. See it on IssueHunt

posted by IssueHuntBot about 6 years ago

I think this is already fixed, should close.

posted by fisker over 3 years ago

@fisker Do you know which commit fixed it?

posted by sindresorhus over 3 years ago

Maybe I fixed it? The old one only ignore DEFAULT_IGNORES, and I removed it, see this.

But I read the ignores config, and use it in another PR https://github.com/xojs/xo/pull/584/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R154

posted by fisker over 3 years ago
posted by fisker over 3 years ago
posted by fisker over 3 years ago

@sindresorhus has rewarded $72.00 to @pvdlg. See it on IssueHunt

  • :moneybag: Total deposit: $80.00
  • :tada: Repository reward(0%): $0.00
  • :wrench: Service fee(10%): $8.00
posted by issuehunt-app[bot] over 3 years ago

Fund this Issue

$80.00
Rewarded

Rewarded pull request

Other pull requests

Recent activities

pvdlg was rewarded by sindresorhus for xojs/xo# 235
over 3 years ago
sindresorhus submitted an output to  xojs/ xo# 235
over 3 years ago