Setup auto-publishing for Safari version #3686

@darthshadow has funded $10.00 to this issue.

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

@fregante has funded $10.00 to this issue.

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

@lautis would you like to copy your fastlane setup to this repo?

I think that the Safari version might need some changes to manifest.json, so feel free to copy the distribution folder to distribution-safari in a build step if necessary.

can pick this up in the morning if that's ok

Yes please!

Hey guys just finished reading the docs for fastlane and the great work over at lautis/refined-github-safari/fastlane

So far I have 1 issue related to certificates - looking at docs.fastlane.tools/actions/match I believe sharing a provisioning profile would reduce the safari github action to:

npm run build
bundle exec fastlane sign

Due to limitations I understand the appstore lane should be on a manual trigger to avoid potential double submit ?

If match is not appealing (overhead) the other simple solution would be to set up a CI machine with a temporary application password. I value this approach because it enables rapid development on a beta/staging lane with hardcoded Appfile values as described in docs.fastlane.tools/advanced/Appfile

While the above methods are friendly enough for non-apple developers to contribute on the extension, my main motivation is keeping the workflow logic (setting up ruby, node, auth and running commands) separated from fastlane and app store flows.

If that sounds good I would be happy to move forward with a CI provisioning profile and automated github action builds for a pre-production environment - this can be used as an artifact to solve spam lagging app store releases or just compare with live version.

TL;DR: Apple release process can be hacked quickly but I am not experienced enough in solving the credentials issue :D

Happy to know your thoughts !

Will Safari version support macOS 10.14 Mojave? Hope so! Thanks.

Yes, if you have Safari 14.

Thank you!

If match is not appealing (overhead) the other simple solution would be to set up a CI machine with a temporary application password. I value this approach because it enables rapid development on a beta/staging lane with hardcoded Appfile values as described in docs.fastlane.tools/advanced/Appfile

I prefer the CI machine approach. I would like the simplest setup possible.

An anonymous user has funded $20.00 to this issue.

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

Got this working locally without having to tick the "Allow Unsigned Extensions" box every time you launch Safari. Basically @fregante 's instructions above, then the self-signing instructions from https://stackoverflow.com/questions/62748163/how-can-i-sign-a-safari-extension-for-just-one-computer.

git clone https://github.com/sindresorhus/refined-github && cd refined-github

# The GitHub enterprise "allow on this website" bit wasn't working in Safari, so I edited distribution/manifest.json
# To change github.com to github.mycompany.com with:
# gsed -i 's/github.com/github.mycompany.com/g' distribution/manifest.json

npm install
npm run build
npm run pack:safari
npm run start:safari

# Open app in Xcode
open "safari/Refined GitHub.xcodeproj"

In Xcode:

• Menu Bar -> Product -> Archive
• Click "Distribute App"
• Click "Development"
• Sign in with Apple ID and register for the (free) developer account if you haven't already
• Choose <Me> (Personal Team)
• Automatically manage signing
• Export
• Save to somewhere, e.g. ~/tmp
• Close Xcode

Outside of Xcode:

• Move the app inside the folder you just exported to /Applications, e.g. mv ~/tmp/Refined GitHub*/Refined GitHub.app /Applications
• Open the app: open /Applications/Refined GitHub.app
• Click the button on the app when it opens to open Safari extension preferences.
• Enable app in preferences.
• Open your github homepage, click the app in the Safari URL bar, click "Allow always for this website"

Then everything started working for me.

To get Fastlane configured, we will need to provide Apple ID developer credentials. Is it safe to assume that the project maintainer (@sindresorhus), or a collaborator @sindresorhus trusts and specifically delegates to should handle this?

I just fixed some issues in the Safari version due to my dependencies, but I haven't updated them here yet.

• https://github.com/fregante/webext-options-sync-per-domain/releases/tag/v2.0.2
• https://github.com/fregante/webext-options-sync/releases/tag/v2.0.1

Any news on this issue? I am using a self-built version, but I am looking forward to the official release. <img width="187" alt="image" src="https://user-images.githubusercontent.com/33802186/103971480-adaa3980-51a5-11eb-83b8-9c0c4ddf4c12.png">

Apple rejected the extension because "GitHub" is a trademarked name. We are working with GitHub on getting it approved. It will probably be another month until it's in the store though.

@sindresorhus you can rephrase it as "Refined for GitHub" in the App Store listing. The app file can keep the Refined GitHub name.

I had this years ago with a stats viewer for Mario Kart 8, I originally called it "Mario Kart 8 Combo Explorer" but in the end I had to call it "Combo Explorer for Mario Kart 8" under the advice of Apple App Store staff. There are lots of examples of this sort of thing on the store, search "for".

eg.

• Streaks for GitHub https://apps.apple.com/gb/app/streaks-for-github/id1274680634?mt=12
• Duplicate Cleaner for iPhoto https://apps.apple.com/gb/app/duplicate-cleaner-for-iphoto/id586862299?mt=12
• Sourcegraph for Safari https://apps.apple.com/gb/app/sourcegraph-for-safari/id1543262193?mt=12
• Simplified for Twitter https://apps.apple.com/gb/app/simplified-for-twitter/id1479307973?mt=12
• FreeChat for WhatsApp https://apps.apple.com/gb/app/freechat-for-whatsapp/id1084346074?mt=12

Of course there are also a bunch of apps that use GitHub in the normal way without issue!

Right, but we are getting the approval, so it’s just a matter of waiting.

If that's the case it wasn't clear from Sindre's post, which was less definite.

An anonymous user has funded $10.00 to this issue.

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

An anonymous user has funded $10.00 to this issue.

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

Right, but we are getting the approval, so it’s just a matter of waiting.

Does anyone know how long it might take? Should I wait or just build & install myself?

🔔

For the time being, everyone here is better off using https://github.com/lautis/refined-github-safari since it automatically updates via homebrew.

I also just followed @gibfahn’s instructions and created an official signed app of v21.3.5, but this lacks autoupdating so it's only good for testing. Download it from https://github.com/sindresorhus/refined-github/releases/tag/21.3.5

I see that this test build 21.3.5 requires macOS 10.15 or higher.

It would be good if Safari 14 on macOS 10.14.6 could be supported, as previously mentioned: https://github.com/sindresorhus/refined-github/issues/3686#issuecomment-734803755

Thank you

FWIW I've been happily using the one I built back in January without any issues. Yeah it's out of date now, but the small subset of features I actually use daily has been very solid.

What's the latest on the Safari Extension App Store rollout?

I'm happy to announce that it's finally available: https://apps.apple.com/app/id1519867270

Backstory: GitHub has been very helpful. They got their lawyers to draft up a trademark license agreement for the name REFINED GITHUB 👍

Please let us know if anyone else encounters this issue: https://github.com/sindresorhus/refined-github/issues/4216

Also question for new users: did the extension open https://github.com/sindresorhus/refined-github/issues/3543 on install?

Also question for new users: did the extension open #3543 on install?

@fregante After enabling the extension in Safari Extensions Preferences, this page does not open for me.

Oh no, this is 10.15 and above?

Is there any chance to support Safari 14 on 10.14.6 as was previously promised?

It only requires a build setting change @sindresorhus

Also question for new users: did the extension open #3543 on install?

Nope! It put a bar on the top of my webpage asking me if I wanted to enable the extension. Clicking on the toolbar icon then crashed Safari Technology Preview. Relaunching STP, clicking the extension, and choosing “always allow for this website” enabled Refined GitHub. Perhaps the page was not opened because I’d built the Safari extension locally previously?

@lautis would you be able to take a look at this?

it shouldn't be closed @fregante? 🤔

@renatobenks this issue is about automatic publishing. Sindre has been manually publishing the Safari releases and that's why we've been skipping versions (currently one month behind)

Why did not some one try Fastlane to solve this problem?

We’re just waiting for a PR. 😉 FastLane is mentioned in the post, that’s the whole reason of this issue.

Sorry @fregante, I didn't read the whole thread, so I just misunderstood that self-publishing was done alongside safari first published.

But I see it now, thanks for clarifying. I'll give it a shot for helping out!

@fregante has funded $40.01 to this issue.

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

@sindresorhus has funded $100.00 to this issue.

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

I'm happy to announce that it's finally available: https://apps.apple.com/app/id1519867270

So the latest on RGH on Safari is that it's available 👆🏻 and fully functional, but this issue is still open because currently it has to be manually updated with the latest changes?

Correct