The issue has been solved
GitHub has had this really annoying bug that changes PR commit links (e.g. this one) into non-PR-related links like this: https://github.com/sindresorhus/refined-github/commit/cb44a4eb8cd5c66def3dc26dca0f386645fa29bb
This only happens to auto-linked URLS like https://...etc and not to [text](https://...etc)
We can't fix these links after they've been submitted but we can do it before submission.
This feature should should:
- Listen to comment form submissions
- Detect plain URLs to PR commits (and skip markdown links)
- Replace plain urls with identical markdown links, like
[https://...etc](https://...etc)
Step 2 is easy to implement in most places (e.g. find a URL surrounded by spaces) but it can be tripped with content like [this url https://... is the problem](https://...) (which... probably does not happen)
Test comment content:
https://github.com/sindresorhus/refined-github/pull/3/commits/cb44a4eb8cd5c66def3dc26dca0f386645fa29bb
cc @lukehefson just in case he can fix this internally.
Thanks for the ping @fregante! Did you submit a bug report to our Support team? And if so, do you think you could DM (twitter, email) me the ticket reference?
posted by issuehunt-app[bot] about 5 years ago 
looks like this was solved?
posted by fregante almost 5 years ago Nope. I just posted 1 but the link points to 2
1. https://github.com/sindresorhus/refined-github/pull/3/commits/cb44a4eb8cd5c66def3dc26dca0f386645fa29bb
2. https://github.com/sindresorhus/refined-github/commit/cb44a4eb8cd5c66def3dc26dca0f386645fa29bb
This issue is considered solved (by GitHub) when the link I just posted points to a PR commit, not a plain commit.
posted by max-arias almost 5 years ago posted by max-arias almost 5 years ago posted by issuehunt-app[bot] almost 5 years ago 
This is really cool—the find of feature that makes me proud to use Refined GitHub. Nice work everyone. The styling of the warning is especially nice.
Glad you like it, this bug annoyed me for a long time.
Some fixes to this feature are coming in #3223
This doesn't really explain why GitHub changing the link is a problem. I.e. what is wrong with the link they transform the original into?
Great feature! Minor inconsistency with GitHub:
When publishing a link in another repo, it should be like this:
Maxim-Mazurok/google-api-typings-generator@429318c
and not like this:
429318c
This doesn't really explain why GitHub changing the link is a problem. I.e. what is wrong with the link they transform the original into?
The difference is subtle, but you can open the 2 links in the first paragraph of this PR and compare them.
What the user pastes:
// https://github.com/sindresorhus/refined-github/pull/3/commits/cb44a4eb8cd5c66def3dc26dca0f386645fa29bb
What GitHub displays:
// https://github.com/sindresorhus/refined-github/commit/cb44a4eb8cd5c66def3dc26dca0f386645fa29bb
In short: The correct link shows the commit on the PR page, while GitHub drops this piece of information, showing a link to the plain commit, without any connection to the PR.
@Maxim-Mazurok I opened an issue about that, thanks!
So if you want to link to commit, it's fine to go with GitHub's version and if you want to show the commit in context of the PR then use the button to fix the link. Makes sense.
I wondered if they do that because the link in PR context can become stale, like if the commit is rebased, but I guess the direct commit link could also then become stale after GC.
Anyway, thanks for the feature and the explanation.
IssueHunt