sindresorhus/refined-github

Submit pending review comment as "single comment" #2063

fregante posted onGitHub

  1. Answer a review comment, like https://github.com/sindresorhus/refined-github/pull/1271/files#r183043274
  2. Press "Start review" instead of "Add single comment"
  3. Be stuck with a pending answer that's not supposed to be a whole new review

<img width="804" alt="Screenshot 2019-05-21 at 21 02 57" src="https://user-images.githubusercontent.com/1402241/58098386-0b25f700-7c0c-11e9-85f3-1645e2bae404.png">

Sometimes I just want to leave a single comment. It's almost ok if it's a new comment (I can just press "Submit review" as comment), but if you're answering an existing thread, it will look strange on the Conversation tab, disconnected from the original comment.

I wish that clicking "Pending" would send the comment instantly (after confirm()). I'm not sure if this is feasible because you probably have to reuse another autenticity token from the page.


This happens to me many times a week...

posted by sindresorhus almost 6 years ago

@issuehunt has funded $60.00 to this issue.


posted by IssueHuntBot almost 6 years ago

I looked into this and:

  1. Write comment A, start review
  2. Write comment B, use RGH to send as single comment (can be done via single_comment=true parameter)
  3. Both comments are now sent as a review, even if I sent a single form for a single comment.

It looks like GitHub's backend will just flush the review queue if you ask for one comment to go through.

This can only work if you want to send the first comment you write:

  1. Write comment A, start review
  2. Use RGH to send A as single comment

But you'll have to cancel the review first and then send the comment

posted by bfred-it almost 6 years ago

@sindresorhus has rewarded $54.00 to @fregante. See it on IssueHunt

  • :moneybag: Total deposit: $60.00
  • :tada: Repository reward(0%): $0.00
  • :wrench: Service fee(10%): $6.00
posted by issuehunt-app[bot] over 5 years ago

WHY

posted by descartes-tlc over 5 years ago

Does it work?

posted by Ayesha-Siddiqa2 almost 4 years ago

Fund this Issue

$60.00
Rewarded

Rewarded pull request

Recent activities

fregante was rewarded by sindresorhus for sindresorhus/refined-github# 2063
over 5 years ago
bfred-it submitted an output to  sindresorhus/ refined-github# 2063
almost 6 years ago