sindresorhus/refined-github

The issue has been solved

Comment indicators when comments are hidden on PR review #1999

zephraph posted onGitHub

When I'm reading through changes on a PR I generally like to do so with the comments hidden. Comments can take up large parts of the screen.

<img width="1035" alt="image" src="https://user-images.githubusercontent.com/3087225/56922907-4adb4200-6a97-11e9-87b1-76c3b7282f24.png">

I find myself toggling comments on and off though. When comments are hidden (especially on a long PR) I don't know where comments are that I might care about. So there's this all or nothing approach... Enable comments and try to read the changes around them or disable comments and miss context.

I'd like to be able to hide comments, but to have positional placeholders where comments appear. It'd also be useful to be able to expand/collapse comments on those placeholders.

I'm not great at design, but it could be something like the below:

Frame

Clicking on the convo icon would expand the comments.

@issuehunt has funded $40.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

posted by IssueHuntBot almost 6 years ago

@jerone has funded $5.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

posted by issuehunt-app[bot] over 5 years ago

I would like to have this too! Can I work on this if no one else is doing?

posted by sidvishnoi over 5 years ago

@fregante Is there something left on my side for the IssueHunt bounty?

posted by sidvishnoi over 5 years ago

@sidvishnoi I think @sindresorhus hasn't had time to do so. More issues aren't rewarded yet.

posted by jerone over 5 years ago

@sindresorhus has rewarded $40.50 to @sidvishnoi. See it on IssueHunt

:moneybag: Total deposit: $45.00
:tada: Repository reward(0%): $0.00
:wrench: Service fee(10%): $4.50

posted by issuehunt-app[bot] over 5 years ago

Fund this Issue

$45.00

Rewarded

issuehunt(32,559)$40.00

jerone(158)$5.00

Rewarded pull request

Add `review-comments-hidden-indicator` feature #2320submitted bysidvishnoi(21)

Share on Facebook

Share on Twitter

Send via e-mail

Click to copy link

Recent activities

sidvishnoi was rewarded by sindresorhus for sindresorhus/refined-github# 1999

over 5 years ago

sidvishnoi submitted an output to sindresorhus/ refined-github# 1999

over 5 years ago

Company

Community

Support

FAQ Terms of use Privacy policy Code of conduct Credits

Connect

Facebook Twitter

© 2019 BoostIO, Inc.