sindresorhus/refined-github

Change PR title to match merge commit title #1743

bfred-it posted onGitHub

Point: the merge commit of PRs should match the PR title.

We have a feature that automatically picks up the PR title to use as the commit title, but if we then change it (e.g. from “Update index.js” to something more apt) the PR will stay with the old title.


This feature may be unwanted, so it may warrant a checkbox like “also update the PR title”… or just a dynamic notice.

The title change can happen after the merge is done successfully and will have to remove the (#124) reference to the PR itself


This seems to be cropping the PR title after a merge. GitHub automatically cropped the PR title when creating the commit message, then Refined GitHub changed the PR title to the "cropped" version, check what happened here in the end (I fixed it manually in the last rename):

https://github.com/reaktoro/reaktoro/pull/116#event-2629067458

For now I have manually disabled sync-pr-commit-title:

image

posted by tadeu over 5 years ago

@tadeu Thank you for the report, I saw this now.

Fixed in https://github.com/sindresorhus/refined-github/pull/2738 It will be published hopefully next week

posted by fregante about 5 years ago

Fund this Issue

$60.00
Rewarded

Rewarded pull request

Recent activities

bfred-it was rewarded by sindresorhus for sindresorhus/refined-github# 1743
almost 6 years ago
bfred-it submitted an output to  sindresorhus/ refined-github# 1743
almost 6 years ago