Old events don't work on history.back() #1247

@issuehunt has funded $80.00 to this issue.

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

the originial reproduce instructions no longer apply: this is better showcase- https://github.com/sindresorhus/refined-github/issues/1608.

we could potentially proxy document addeventlisteners

Or can we listen to history changes and remove & re-apply all listeners? Or would delegated events be a more efficient fix?

Or can we listen to history changes and remove & re-apply all listeners

That's kinda complicated because events are attached when creating the dom (e.g. <a onClick={handler}>), so taking these two pieces apart seems messy, also because each feature's init function is generally not re-run when the ajax page changes.

I think a good way to go about solving this issue is figuring out why this is happening;

• How can the dom exist without the listeners?
• What's the GitHub code that takes care of this behavior?
• How does GitHub handle their own events? They might be all delegate events

I inspected the page, Github's click targets seem to have a data-hydro-click attribute with a JS object as its value, which contains details regarding the event. I couldn't find anything else on that attribute though; maybe it's some internal library that they use? I think our way to solve this would be by using delegated events in the app, maybe using @bfred-it 's library delegate-it. What's you take?

I think our way to solve this would be by using delegated events in the app, maybe using @bfred-it 's library delegate-it. What's you take?

Delegated events would indeed work, but that means using global delegated events for everything. It's a solution but not what we're looking for, there would be too many click listeners and eventually that's gonna slow you down.

@sindresorhus has rewarded $72.00 to @fregante. See it on IssueHunt

• :moneybag: Total deposit: $80.00
• :tada: Repository reward(0%): $0.00
• :wrench: Service fee(10%): $8.00