sindresorhus/gulp-tar

Fix broken test #23

sindresorhus posted onGitHub

https://github.com/sindresorhus/gulp-tar/blob/e54fb9f43490460641be4af147775c72308c0f7f/test.js#L93 currently errors out with:

1) should include directories:
     Uncaught Error: already started
      at Cloneable.clone (node_modules/cloneable-readable/index.js:38:11)
      at File.clone (node_modules/vinyl/index.js:117:30)
      at map (node_modules/vinyl-map/index.js:32:17)
      at BufferList._callback (node_modules/vinyl-map/index.js:26:7)
      at BufferList.end (node_modules/bl/bl.js:104:10)
      at Cloneable.onend (node_modules/readable-stream/lib/_stream_readable.js:499:10)
      at endReadableNT (node_modules/readable-stream/lib/_stream_readable.js:920:12)
      at _combinedTickCallback (internal/process/next_tick.js:138:11)
      at process._tickCallback (internal/process/next_tick.js:180:9)

@issuehunt has funded $10.00 to this issue.


posted by IssueHuntBot about 6 years ago

Your Travis CI looks working very well.

posted by chinesedfan about 6 years ago

@chinesedfan That's because the broken test is skipped.

posted by sindresorhus about 6 years ago

I will take a look at this issue this weekend. 👍

posted by Mike-Neto over 5 years ago

I pushed a fix for it in as this clone was causing issues when mapping a stream. https://github.com/affirmix/vinyl-map/pull/6 When that fix gets published we should be able to remove the skip on the test.

Essentially the issue revolved around cloneable-readable/index.js:90 pipe cloning and cleaning up the _original value, which then vinyl-map uses when trying to clone it, since it was already cleaned up, there is nothing to clone and it throws.

There are also some deprecations & issues with the node engine version necessary to clean those up which I will address in a separate PR to enable proper CI (which has failed with syntax errors in the last merged PR).

posted by Mike-Neto over 5 years ago

@sindresorhus has rewarded $9.00 to @big-kahuna-burger. See it on IssueHunt

  • :moneybag: Total deposit: $10.00
  • :tada: Repository reward(0%): $0.00
  • :wrench: Service fee(10%): $1.00
posted by issuehunt-app[bot] over 5 years ago

Fund this Issue

$10.00
Rewarded

Rewarded pull request

Recent activities

big-kahuna-burger was rewarded by sindresorhus for sindresorhus/gulp-tar# 23
over 5 years ago