sindresorhus/caprine

Bug with emoji selector #831

Saalik posted onGitHub

<!-- Please succinctly describe your issue and steps to reproduce it. -->

When you go into a conversation if you click on the emoji button everything is fine.

You click, you choose, you remove the chooser. Then if you use cmd+e works.

Now going into any conversation if you use cmd+e to open the selector, you choose your emoji, close it again with cmd+e and try to continue your message it will keep opening the emoji selector.

Workaround: Switch between conversation to unlock it and use the emoji button with mouse first then cmd+e won't trigger the bug

Video


Caprine 2.30.1 Electron 4.1.0 darwin 18.2.0 Locale: fr


@issuehunt has funded $40.00 to this issue.


posted by IssueHuntBot almost 6 years ago

I tested and this issue does not seem to be reproducible anymore. @Saalik can you check again with the latest version and confirm its fixed?

posted by pkuczynski almost 6 years ago

Just tested again and still having the issue.

This is my build number: Version 2.31.2 (2.31.2.1405)

Restarted the app three time and still got the same issue.

posted by Saalik almost 6 years ago

I've researched this issue a while back, and I got a half-complete fix.

It turned out to be a quite complex problem. Long story short - we mostly interact with Messenger's UI by click() function on elements, which doesn't trigger events like mouseover, mousedown, etc. Those event's are sometimes used by Messenger to, for example, asynchronously load code. That's the case with emoji selector.

The fix is twofold:

  1. Trigger all events that would be created by manually clicking an element, instead of calling click
  2. Wait for Messenger to async load any new code before resuming current action

I'll come back to it (soon-ish) and will submit a PR.

posted by CvX almost 6 years ago

Interesting. Is this specific to OS or Messenger version? Asking, as I am not experiencing this issue at all. Never did.

posted by pkuczynski almost 6 years ago

@pkuczynski What OS are you on ?

posted by Saalik almost 6 years ago

@pkuczynski The OS shouldn't matter. I don't know if it's as easily replicable in the new Messenger UI, but on the old one the reliable way is to restart Caprine and press cmd+E. The emoji popover either never loads or shows up after 5-20 seconds, and then clicking the emoji button in the composer doesn't hide the popover.

posted by CvX almost 6 years ago

@sindresorhus has rewarded $36.00 to @whitecrownclown. See it on IssueHunt

  • :moneybag: Total deposit: $40.00
  • :tada: Repository reward(0%): $0.00
  • :wrench: Service fee(10%): $4.00
posted by issuehunt-app[bot] over 5 years ago

Fund this Issue

$40.00
Rewarded

Rewarded pull request

Recent activities

whitecrownclown was rewarded by sindresorhus for sindresorhus/caprine# 831
over 5 years ago
whitecrownclown submitted an output to  sindresorhus/ caprine# 831
over 5 years ago