saberland/saber

Windows path issue in $saber.getPageLink #460

egoist posted onGitHub

<!-- Please don't delete this template or we'll close your issue -->

<!-- Before creating an issue please make sure you are using the latest version of Saber. -->

<!-- Issues which contain questions or support requests will be closed. -->

<!-- Please ask questions via following several ways. -->

<!-- https://chat.saber.land/ -->

<!-- https://stackoverflow.com/questions/ask?tags=saberjs -->

Bug report

https://github.com/saberland/saber/blob/ac3f80d415071186e92ffa3266ff78444500b85c/packages/saber/vue-renderer/app/create-app.js#L128-L138

In line 137 route.meta.__relative is a path separated by slash /, but relativePath is separated by backslash \ on Windows (since we're using path.join in line 128.

Other relevant information

  • Result of running saber -v: saber/0.9.0 darwin-x64 node-v10.16.2

It would be great if we can just get rid of using path in the fix.

posted by egoist over 5 years ago

I will just say that relativePath.replace(/\\/g, '/') fix the problem

posted by MarchWorks over 5 years ago

@issuehunt has funded $40.00 to this issue.


posted by issuehunt-app[bot] over 5 years ago

@egoist has rewarded $28.00 to @egoist. See it on IssueHunt

  • :moneybag: Total deposit: $40.00
  • :tada: Repository reward(20%): $8.00
  • :wrench: Service fee(10%): $4.00
posted by issuehunt-app[bot] over 5 years ago

Fund this Issue

$40.00
Rewarded

Rewarded pull request

Other pull requests

Recent activities

egoist was rewarded for saberland/saber# 460
over 5 years ago
egoist submitted an output to  saberland/ saber# 460
over 5 years ago