saberland/saber

Website: Change the hash while scrolling #151

egoist posted onGitHub

Thanks to #145, we can also do this now:

<img width="336" alt="屏幕快照 2019-05-07 下午11 43 55" src="https://user-images.githubusercontent.com/8784712/57313343-ff253a00-7121-11e9-84f9-c1efcf002435.png">

  • Show headings
  • Detect scrolling
  • Make sidebar section collapsible

@issuehunt has funded $50.00 to this issue.


posted by IssueHuntBot almost 6 years ago

I'll implement this and #163 in one rush.

posted by krmax44 almost 6 years ago

@krmax44 I am working on this the PR is ready soon

posted by MarchWorks almost 6 years ago

@krmax44 I am working on this the PR is ready soon

Awesome! :+1:

@egoist is it possible to allow self-assigning to issues? That way it'd be easy to see what is currently being worked on by who.

posted by krmax44 almost 6 years ago

@saberland/core are able to self-assign issues now.

posted by egoist almost 6 years ago

What about showing the markdown headings here instead?

<img width="1868" alt="屏幕快照_2019-05-12_下午5_16_52" src="https://user-images.githubusercontent.com/8784712/57580259-e9c15e80-74d9-11e9-83a2-1be3c073abef.png">

posted by egoist almost 6 years ago

Hmm, most people are probably more familiar with it being included, as its used by most documentation sites. Personally, I also find it looks cleaner there.

Bildschirmfoto von 2019-05-12 11-22-58

Bildschirmfoto von 2019-05-12 11-23-54

posted by krmax44 almost 6 years ago

Showing the toc in a different place than the sidebar will make the UI design quite messy precisly for small screen.

posted by MarchWorks almost 6 years ago

Showing the toc in a different place than the sidebar will make the UI design quite messy precisly for small screen.

Of course, we can move the toc to sidebar or somewhere else for small screens.

Actually, https://apollographql.com/docs and https://next.tailwindcss.com simply omit the toc on mobile devices. 😅

posted by egoist almost 6 years ago

And sites like https://reactjs.org and https://adonisjs.com display toc inside the page content:

<img width="875" alt="屏幕快照_2019-05-12_下午7_45_00" src="https://user-images.githubusercontent.com/8784712/57581752-8d1c6e80-74ee-11e9-9830-81ca9254f77b.png">

posted by egoist almost 6 years ago

I like how https://apollographql.com/docs do it, if you agree tell me and I will implement it.

posted by MarchWorks almost 6 years ago

btw, in mkdocs, tocs are shown in right hand side too (https://squidfunk.github.io/mkdocs-material/

posted by Ir1d almost 6 years ago

@MarchWorks Are you still working on this?

posted by egoist over 5 years ago

@egoist I will make a PR for it today

posted by MarchWorks over 5 years ago

@egoist has rewarded $35.00 to @marchworks. See it on IssueHunt

  • :moneybag: Total deposit: $50.00
  • :tada: Repository reward(20%): $10.00
  • :wrench: Service fee(10%): $5.00
posted by issuehunt-app[bot] over 5 years ago

Fund this Issue

$50.00
Rewarded

Rewarded pull request

Recent activities

marchworks was rewarded by egoist for saberland/saber# 151
over 5 years ago
marchworks submitted an output to  saberland/ saber# 151
over 5 years ago