remotion-dev/remotion

The issue has been solved

Old Node/FFMPEG version should trigger an error even when rendering via Node.JS APIs #1359

JonnyBurger posted onGitHub

🎃 This issue is part of our Hacktoberfest campaign! 📚 Read more about Hacktoberfest here 🕛 This issue is currently taken by @JRavi2!

Hacktoberfest Acceptance Criteria

Currently in the CLI we check for the FFMPEG version: https://github.com/remotion-dev/remotion/blob/33668831b0335fcf1ff5580e53046dad97ff6273/packages/cli/src/validate-ffmpeg-version.ts#L8
And for the Node.JS version: https://github.com/remotion-dev/remotion/blob/33668831b0335fcf1ff5580e53046dad97ff6273/packages/cli/src/check-version.ts#L16
These checks should be moved into the renderer package so the warnings also appear when using the Node.JS APIs.
The Node.JS version should be immediately checked once the @remotion/renderer package is loaded.
The FFMPEG version should be checked before renderMedia(), renderFrames(), getCompositions(), stitchFramesToVideo() gets called.

@jonnyburger has funded $112.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

posted by issuehunt-app[bot] over 2 years ago

Hi @JonnyBurger ,

can I take this issue? I think I can handle this.

Thanks

posted by wa-candra over 2 years ago

@wa-candra Yes, you got it!

posted by JonnyBurger over 2 years ago

Hey @wa-candra @JonnyBurger, is this still active? If not, can I pick up this issue?

posted by JRavi2 over 2 years ago

Since the issue got inactive, a I'll hand it over to you! Just checking if @wa-candra has not already started working on it?

posted by JonnyBurger over 2 years ago

Ok, you take it @JRavi2 :)

posted by JonnyBurger over 2 years ago

@jonnyburger has rewarded $100.80 to @jravi2. See it on IssueHunt

:moneybag: Total deposit: $112.00
:tada: Repository reward(0%): $0.00
:wrench: Service fee(10%): $11.20

posted by issuehunt-app[bot] over 2 years ago

Fund this Issue

$112.00

Rewarded

jonnyburger(2,210)$112.00

Rewarded pull request

Move version checks for node and ffmpeg to the renderer package #1412submitted byjravi2(36)

Share on Facebook

Share on Twitter

Send via e-mail

Click to copy link

Recent activities

jravi2 was rewarded by jonnyburger for remotion-dev/remotion# 1359

over 2 years ago

jonnyburger submitted an output to remotion-dev/ remotion# 1359

over 2 years ago

Company

Community

Support

FAQ Terms of use Privacy policy Code of conduct Credits

Connect

Facebook Twitter

© 2019 BoostIO, Inc.