remotion-dev/remotion

volume component of Player is not responsively designed #1352

UmungoBungo posted onGitHub

šŸŽƒ This issue is part of our Hacktoberfest campaign! šŸ“š Read more about Hacktoberfest here šŸ•› This issue is currently assigned to @Pompette and is not for the taking.

<!--- Provide a general summary of the issue in the Title above -->

Bug Report šŸ›

When using the Player component in a portrait view, with a narrow width, the volume controller is not responsively designed. Pehaps it should be a vertical control when there is a narrow width?

https://user-images.githubusercontent.com/22192773/193221768-1f8f00d9-2702-4333-829d-3112180e7dbe.mp4

<!-- To make it easier for us to solve your issue, please help us by writing your issue in a way that we can reproduce the bug yourself. Include relevant information like exception messages, screenshots, example code snippets, information about your environment and the Remotion version you are using. Common problems are also explained in the "Troubleshooting" section under https://www.remotion.dev/docs/ -->


Good point! We should improve this - a vertical control sounds like a smart idea! I will add a bounty for it during Hacktoberfest and see if somebody picks it up, otherwise we'll solve it ourselves.

posted by JonnyBurger over 2 years ago

@jonnyburger has funded $167.00 to this issue.


posted by issuehunt-app[bot] over 2 years ago

@JonnyBurger I would like to take up this issue. Can you assign this to me please?

posted by imrishabh18 over 2 years ago

@imrishabh18 It was already started by @Pompette unfortunately! Mind taking another issue with the Hacktoberfest label?

posted by JonnyBurger over 2 years ago

Okay, the issues here on GitHub labeled hacktoberfest is not assigned to anybody. So, can't make out which one's are up-for-grabs?

posted by imrishabh18 over 2 years ago

Acceptance criteria for this PR:

  • Make slider go upwards if space is not sufficient
  • Be resilient if used in Next.JS server-side rendering / React strict mode
posted by JonnyBurger over 2 years ago

@imrishabh18 Sorry, I'm still preparing all the issues and will mention in each one of them clearly which ones are taken and how to claim one. Check back in a few hours!

posted by JonnyBurger over 2 years ago

@jonnyburger has rewarded $150.30 to @pompette. See it on IssueHunt

  • :moneybag: Total deposit: $167.00
  • :tada: Repository reward(0%): $0.00
  • :wrench: Service fee(10%): $16.70
posted by issuehunt-app[bot] over 2 years ago

Fixed by #1356

posted by JonnyBurger over 2 years ago

Fund this Issue

$167.00
Rewarded

Rewarded pull request

Recent activities

pompette was rewarded by jonnyburger for remotion-dev/remotion# 1352
over 2 years ago
pompette submitted an output to  remotion-dev/ remotion# 1352
over 2 years ago