remotion-dev/remotion

`npx remotion lambda render` does not derive the codec from the file extension #1248

JonnyBurger posted onGitHub

šŸŽƒ This issue is part of our Hacktoberfest campaign! šŸ“š Read more about Hacktoberfest here šŸ•› This issue is currently assigned to @uragirii!

Problem

npx remotion lambda render --out-name=hi.mp3 or npx remotion lambda render ... out.mp3 should assume MP3 codec.

Acceptance criteria:

  • Should handle npx remotion lambda render [serve-url] [comp-name] --out-name=out.mp3 (higher priority)
  • Should handle npx remotion lambda render [serve-url] [comp-name] out.mp3
  • Should error when a conflicting setting is used npx remotion lambda render [serve-url] [comp-name] --out-name=out.mp3 --codec=gif, reuse code from packages/renderer/src/validate-output-filename.ts
    • Ideally: Add this validation to renderMediaOnLambda() as well to catch the same error when using Node.JS APIs
  • Should derive .png / .jpeg codec when using npx remotion lambda still (same logic as here: https://github.com/remotion-dev/remotion/blob/33668831b0335fcf1ff5580e53046dad97ff6273/packages/cli/src/still.ts#L42)
    • Ideally: Add this validation to renderMediaOnLambda() as well to catch the same error when using Node.JS APIs

@jonnyburger has funded $111.00 to this issue.


posted by issuehunt-app[bot] over 2 years ago

Acceptance criteria:

  • Should handle npx remotion lambda render [serve-url] [comp-name] --out-name=out.mp3 (higher priority)
  • Should handle npx remotion lambda render [serve-url] [comp-name] out.mp3
  • Should error when a conflicting setting is used npx remotion lambda render [serve-url] [comp-name] --out-name=out.mp3 --codec=gif, reuse code from packages/renderer/src/validate-output-filename.ts
    • Ideally: Add this validation to renderMediaOnLambda() as well to catch the same error when using Node.JS APIs
  • Should derive .png / .jpeg codec when using npx remotion lambda still (same logic as here: https://github.com/remotion-dev/remotion/blob/33668831b0335fcf1ff5580e53046dad97ff6273/packages/cli/src/still.ts#L42)
    • Ideally: Add this validation to renderMediaOnLambda() as well to catch the same error when using Node.JS APIs
posted by JonnyBurger over 2 years ago

@jonnyburger has funded $1.00 to this issue.


posted by issuehunt-app[bot] over 2 years ago

@jonnyburger has funded $55.00 to this issue.


posted by issuehunt-app[bot] over 2 years ago

@jonnyburger has rewarded $150.30 to @uragirii. See it on IssueHunt

  • :moneybag: Total deposit: $167.00
  • :tada: Repository reward(0%): $0.00
  • :wrench: Service fee(10%): $16.70
posted by issuehunt-app[bot] over 2 years ago

Fund this Issue

$167.00
Rewarded

Rewarded pull request

Recent activities

uragirii was rewarded by jonnyburger for remotion-dev/remotion# 1248
over 2 years ago
jonnyburger submitted an output to  remotion-dev/ remotion# 1248
over 2 years ago