remotion-dev/remotion

Allow to pass FFMPEG bitrate parameters #1247

JonnyBurger posted onGitHub

πŸŽƒ This issue is part of our Hacktoberfest campaign! πŸ“š Read more about Hacktoberfest here πŸ•› This issue is currently assigned to @Slashgear and up for taking!


Problem

User story from Band on Discord:

I have a related use case. We are also publishing to Instagram via the ig-user/media API (https://developers.facebook.com/docs/instagram-api/reference/ig-user/media#reel-specifications). We’ve had a lot of flakiness with IG throwing vague errors for video uploads in the past, so we have validators that catch discrepancies between the IG specs and the video we are attempting to upload. While the test videos rendered by remotion seem to upload fine, The team is hesitant to remove any validators, since we can point to Instagram as being the source of the issues if we are matching their requirements. It would be convenient if I could add -ab 128 to the ffmpeg call so it passes our validation and everyone is happy.

Hacktoberfest Acceptance criteria

  • Allow to customize -b:v and b:a parameters using a new option for stitchFramesToVideo() and renderMedia()
  • If using renderMediaOnLambda(), the option should also be passed
  • If using the npx remotion lambda render or the npx remotion render commands, new command line flags should be introduced to use the feature from the CLI as well.
  • All APIs that accept the parameter should have their API page updated.

const task = execa(options.ffmpegExecutable ?? 'ffmpeg', ffmpegString, Can add a hook so that developers can control the final ffmpeg command, Is this proposal feasible

posted by gexin1 over 2 years ago

@remotion-dev has funded $167.00 to this issue.


posted by issuehunt-app[bot] over 2 years ago

πŸ‘‹πŸ» @JonnyBurger As I almost finish another issue, maybe I could take that one if you want :)

posted by Slashgear over 2 years ago

@Slashgear You got it! πŸ™Œ

posted by JonnyBurger over 2 years ago

I will send you a draft PR with my intention and vison about it, we need to discuss what the best solution because for now I am not a big fan how the one I took. Maybe the way we pass params to ffmpeg is not clear enough to me.

posted by Slashgear over 2 years ago

@jonnyburger has rewarded $150.30 to @slashgear. See it on IssueHunt

  • :moneybag: Total deposit: $167.00
  • :tada: Repository reward(0%): $0.00
  • :wrench: Service fee(10%): $16.70
posted by issuehunt-app[bot] over 2 years ago

Fixed by #1380

posted by JonnyBurger over 2 years ago

Fund this Issue

$167.00
Rewarded

Rewarded pull request

Recent activities

slashgear was rewarded by jonnyburger for remotion-dev/remotion# 1247
over 2 years ago
jonnyburger submitted an output to  remotion-dev/ remotion# 1247
over 2 years ago