mtxr/vscode-sqltools

Add-Driver fails to run #557

BNMeier posted onGitHub

Describe the bug I am trying to run Add-Driver and getting an error. Based on the error and my limited knowledge of exactly what the add-driver.js is doing, it looks like a recent commit, removed the docs/src/components/checkLocation.ts file which seems to be causing the failure due to a diff conflict.

To Reproduce Steps to reproduce the behavior: Clone the repo run: yarn run: yarn run add-driver

Expected behavior New driver created and ready to be implemented

Screenshots 2020-05-12_17-14-33

Desktop (please complete the following information):

  • SQLTools Version: Newest
  • VSCode Version: 1.44.2
  • Driver Used/Version: NA
  • OS: Windows 10

I'm also getting this error. though i didn't realize i didn't know if i needed to be in vscode terminal for not.

for completeness, i'm adding the contents of a what i see from just a powershell terminal when running the yarn and yarn run add-driver commands: most importantly. its the same critical error error: docs/src/components/checkLocation.ts: No such file or directory

(in addition to various warnings i assume are do to not following instructions of running inside vscode terminal, my bad)

PS C:\projects> git clone https://github.com/mtxr/vscode-sqltools.git
Cloning into 'vscode-sqltools'...
remote: Enumerating objects: 217, done.
remote: Counting objects: 100% (217/217), done.
remote: Compressing objects: 100% (153/153), done.
remote: Total 13318 (delta 91), reused 129 (delta 58), pack-reused 13101
Receiving objects: 100% (13318/13318), 8.24 MiB | 4.44 MiB/s, done.
Resolving deltas: 100% (8833/8833), done.
PS C:\projects> cd .\vscode-sqltools\
PS C:\projects\vscode-sqltools> yarn
yarn install v1.22.0
[1/4] Resolving packages...
[2/4] Fetching packages...
info fsevents@1.2.9: The platform "win32" is incompatible with this module.
info "fsevents@1.2.9" is an optional dependency and failed compatibility check. Excluding it from installation.
warning @sqltools/extension@0.21.7: The engine "vscode" appears to be invalid.
warning vscode-languageclient@5.2.1: The engine "vscode" appears to be invalid.
[3/4] Linking dependencies...
warning " > @sqltools/types@0.0.1" has unmet peer dependency "vscode-languageclient@*".
warning " > @sqltools/types@0.0.1" has unmet peer dependency "vscode-languageserver-protocol@*".
warning " > @sqltools/types@0.0.1" has unmet peer dependency "vscode-languageserver@*".
warning "workspace-aggregator-a881051f-6555-499f-a7e9-2850fc17a715 > @sqltools/extension > @babel/cli@7.7.0" has unmet peer dependency "@babel/core@^7.0.0-0".
warning "workspace-aggregator-a881051f-6555-499f-a7e9-2850fc17a715 > @sqltools/extension > babel-loader@8.0.6" has unmet peer dependency "@babel/core@^7.0.0".
warning "workspace-aggregator-a881051f-6555-499f-a7e9-2850fc17a715 > @sqltools/ui > @devexpress/dx-react-grid@2.2.1" has unmet peer dependency "@devexpress/dx-core@2.2.1".
warning "workspace-aggregator-a881051f-6555-499f-a7e9-2850fc17a715 > @sqltools/ui > @devexpress/dx-react-grid-material-ui@2.2.1" has unmet peer dependency "@devexpress/dx-grid-core@2.2.1".
warning "workspace-aggregator-a881051f-6555-499f-a7e9-2850fc17a715 > @sqltools/ui > @devexpress/dx-react-grid > @devexpress/dx-grid-core@2.2.1" has unmet peer dependency "@devexpress/dx-core@2.2.1".
[4/4] Building fresh packages...
warning Your current version of Yarn is out of date. The latest version is "1.22.4", while you're on "1.22.0".
$ yarn workspace @sqltools/formatter install
yarn workspace v1.22.0
yarn install v1.22.0
[1/4] Resolving packages...
success Already up-to-date.
Done in 0.74s.
Done in 1.21s.
Done in 85.21s.
PS C:\projects\vscode-sqltools> yarn run add-driver --name "jdbc"
yarn run v1.22.0
$ node ./tools/add-driver.js --name jdbc
error: docs/src/components/checkLocation.ts: No such file or directory

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
PS C:\projects\vscode-sqltools>
posted by BrettMoan almost 5 years ago

Can someone please provide the steps to manually add a driver if the Add-Driver code isn't going to be fixed any time soon?

posted by BNMeier almost 5 years ago

An anonymous user has funded $20.00 to this issue.


posted by issuehunt-app[bot] almost 5 years ago

@BNMeier @juanmonsa @alucard17 I need to merge some change on master before fix this. I got some progress during the weekend of the release of next version, so we are close to the big release of v0.22 and that will change the way we handle drivers, so tomorrow possibly we will have more updates on the way we add drivers

posted by mtxr almost 5 years ago

Hey @BNMeier I've just replied you here:

https://github.com/mtxr/vscode-sqltools/issues/466

posted by mtxr almost 5 years ago

Thanks for the reply @mtxr. I spun up a new driver and the recent changes seem to work. I am a little lost in how the plugins now work as it's a different paradigm from the last implementation. Is the idea to clone the SQLTools repo and then run the "yo sqltools-driver" or can you just run the "yo sqltools-driver" by itself and some how it references the SQLTools extension? I am particularly interested in getting the new driver stubbed out and being able to debug it. I am looking to start the work on the Snowflake driver which may present some challenges as it's implementation in the connection is a little different than most database systems. It requires an account, username and password but optionally allows setting things like the default warehouse, role, database, and schema to be defined. I am grateful for any info you provide to get me rolling! Thanks again!

posted by BNMeier almost 5 years ago

Fund this Issue

$20.00
Funded
Anonymous
$20.00

Pull requests

Recent activities

mtxr submitted an output to  mtxr/ vscode-sqltools# 557
almost 5 years ago
mtxr withdrew the output  to  mtxr/ vscode-sqltools# 557
almost 5 years ago