apache/incubator-superset

Add ability to color cells on Pivot Tables #3416

jfeng15 posted onGitHub

A couple of users have requested the ability to color cells on Pivot Tables, either manually or based on certain rules. This issue is to track the addition of that feature.


Hi, all,

Actually, we have implement similar features for pivot table and plain table, in our own branch.

Some screenshot here:

The final table style:

image

Configure table column style based on some rules (like if the value is greater than 100%, then set the cell color to red)

image

Configure table row style based on some rules (like if the row contains some keyword, then highlight the whole row):

image

I was wondering if anybody have interest in this feature. We can consider to contribute back to upstream.

posted by xiaohanyu over 7 years ago

Actually, we have implement similar features for pivot table and plain table, in our own branch.

good features,i also needit.tks!! which branch can try this feature

太棒了,你做的这些新特性在那个分支里呢?多谢啦

posted by gangh over 7 years ago

Hi, @gangh

Right now these feature is hosted on our own internal private codebase, and we're considering to contribute back this feature to upstream in one or two months.

I wrote our work here because I was wondering how many people are interested in this kind of feature.

posted by xiaohanyu over 7 years ago

@xiaohanyu Love the simple implementation! I am interested as well.

posted by markrey over 7 years ago

upstream it!

posted by mistercrunch over 7 years ago

Has this feature been implemented in superset ? .

posted by shyam2794 about 7 years ago

@shyam2794 Right now, no. We're considering contribute our patch to upstream, maybe start from Next January.

And to give you a sneak:

image

posted by xiaohanyu about 7 years ago

@xiaohanyu This looks cool . Thanks for the reply . We are in very much need of this feature . Expecting it to be in superset by Jan.

posted by shyam2794 about 7 years ago

@shyam2794 we will start to do this from Jan, so be patient!

posted by xiaohanyu about 7 years ago

is it done?

posted by kartikshanbhag3333 about 7 years ago

@kartikshanbhag3333 we're working on it from this week. It should be PRed by the end of this month.

posted by xiaohanyu about 7 years ago

Hi guys, currently we are working on this to make it more flexible and more complete, with @xiaohanyu , there are two different design, which one do you think better? image image

@mistercrunch @graceguo-supercat @michellethomas @timifasubaa @shyam2794 @kartikshanbhag3333

posted by WangXueminGit about 7 years ago

The First one looks very useful to me

posted by kartikshanbhag3333 about 7 years ago

@kartikshanbhag3333 oh really? we think the second one looks more aligned considering layout, while the first one looks a little messy about layout.

posted by xiaohanyu about 7 years ago

@xiaohanyu @WangXueminGit 2nd one looks better.

posted by markrey about 7 years ago

@xiaohanyu Yeah I missed some pointers from the 2nd one, 2nd one clearly makes sense..

posted by kartikshanbhag3333 about 7 years ago

@WangXueminGit The second one looks pretty neat .

posted by shyam2794 about 7 years ago

We're almost done.

@WangXueminGit is really working quite hard on this feature and after internal code review, we'll push this to upstream soon.

Here's a small demo of our work:

ezgif com-resize

posted by xiaohanyu about 7 years ago

Hi guys, I made a pr for this issue. Check the pull request #4394 Thanks!!

posted by WangXueminGit about 7 years ago

HI, all, we have updated lots of screenshots in https://github.com/apache/incubator-superset/pull/4394, please vote for us, thanks.

posted by xiaohanyu about 7 years ago

@xiaohanyu I reinstalled superset to use this feature in my machine . But i could not find any row or column configuration in the Pivot table

posted by shyam2794 about 7 years ago

@shyam2794 Hi, this PR is not merged yet, and if you would like to have a try, you have to cherry pick this PR manually by yourself, then you have to recompile the frontend assets.

posted by xiaohanyu about 7 years ago

@xiaohanyu Thanks for the response . So will this feature be applicable even for the plain table other than pivot .And can you provide the tentative timeline regarding when it will be merged .

posted by shyam2794 about 7 years ago

@xiaohanyu @WangXueminGit I tried to implement the PR by myself and it works fine for the pivot visualization and it looks awesome . But you have stated on top of this thread that you have this feature implemented for both the table and pivot . How to implement this feature on plain table ? I am struck with the changes that needs to be done on table.js .

Can you share the code for plain table . It will be of great help .

posted by shyam2794 almost 7 years ago

Any update on merging this to latest version

posted by amitboutiqaat over 6 years ago

give me some time and let me rebase this feature...

posted by xiaohanyu over 6 years ago

I think there is another update version now need to. Met up-to-date.

posted by Moinuddinislam over 6 years ago

Hi @xiaohanyu , I know this might not be in the wrong subject. But how did you guys come up with the subtotal in the pivot table?

posted by bnasavan over 6 years ago

Does anybody know if this feature will be in the next release? Thanks

posted by damir19 about 6 years ago

This is nice feature, when it will be available ?

posted by anitatailor about 6 years ago

+1

posted by dtaytson about 6 years ago

@rororofff has funded $20.00 to this issue.


posted by IssueHuntBot almost 6 years ago

The PR was closed asking for it to be re-submitted as a plugin. Any idea when it will be available as a plugin?

posted by zpanderson almost 6 years ago

@xiaohanyu, @WangXueminGit are you able to release this as a plugin?

posted by davidhassan almost 6 years ago

Hi i used it with superset 0.32 it will be good working and i need to schedule message based on text in the table

posted by kalimuthu123 almost 6 years ago

Fund this Issue

$20.00
Funded
Only logged in users can fund an issue

Pull requests

Recent activities

rororofff funded 20.00 for apache/incubator-superset# 3416
almost 6 years ago