BoostIO/Boostnote

emoji isn't colorful in ubuntu 16.04 #3061

Tao-Zhou posted onGitHub

Current behavior

Using emoji in ubuntu 16.04 with Boostnote, but it is black and white, not colorful.

<!-- Let us know what is currently happening. Please include some screenshots with the developer tools open (console tab) when you report a bug. If your issue is regarding Boostnote mobile, please open an issue in the Boostnote Mobile repo šŸ‘‰ https://github.com/BoostIO/boostnote-mobile. -->

Expected behavior

Expect the emoji can be colorful.

<!-- Let us know what you think should happen! -->

Steps to reproduce

:wave:

<!-- Please be thorough, issues we can reproduce are easier to fix! -->

Environment

  • Version : Boostnote 0.11.17
  • OS Version and name : ubuntu 16.04

<!-- Love Boostnote? Please consider supporting us on IssueHunt: šŸ‘‰ https://issuehunt.io/repos/53266139 -->


@boostio has funded $20.00 to this issue.


posted by IssueHuntBot almost 6 years ago

Running Ubuntu 18.04 and emojis are still black and white. Not sure about other operating systems but it seems like the module being used for these emojis "https://github.com/markdown-it/markdown-it-emoji", only outputs emojis in this form.

When it finds the ": [emoji_name] :", it outputs a token with 2 pieces of info Token.markup - which is the emoji name Token.content - which is the actual emoji, in this case black and white

There is a JSON file that holds all of these emojis boostnoteemojifix

Seems like the only way to make the emojis colorful is to use another module to control the emoji markdown system

posted by rvbcldud almost 6 years ago

I have gotten the emojis to be colored by changing the code in markdown-it-emoji/lib/render.js to:

var twemoji = require('twemoji')

module.exports = function emoji_html(tokens, idx /*, options, env */) {
  if(window.navigator.platform == "Linux x86_64")
  {
    return twemoji.parse(tokens[idx].content, {
      size: '16x16'
    });
  }
  else{
    return tokens[idx].content;
  }
}

With the output of boostnoteemojiix2

posted by rvbcldud almost 6 years ago

The reason why the emoji are black and white in Ubuntu is because system font is used. Ubuntu ships with a font for coloured emoji as well. I simply had to pick it as my primary system font.

https://askubuntu.com/a/1029675/881300

tested with Boostnote 0.11.12 on Linux Ubuntu 19.10

:clap: :clap: :clap:

posted by arcturus140 almost 5 years ago

Thanks for the info @arcturus140!

I think it is safe to close this issue, as the problem has been nailed down, and a solution is available. Boostnote changing the font of only emoji to get them colored would be a solution, but I don't think that will be a pretty solution.

If somebody does have good arguments why Boostnote should solve this instead of the user, then feel free to post those here, and we'll reopen the issue.

posted by Flexo013 almost 5 years ago

Fund this Issue

$20.00
Funded

Pull requests

Recent activities

rvbcldud withdrew the output  to  BoostIO/ Boostnote# 3061
over 4 years ago
rvbcldud submitted an output to  BoostIo/ Boostnote# 3061
almost 6 years ago