Editor themes aren't working since the new release #3018
jacekdudziec posted onGitHub
Since new release, editor themes are not working anymore. Only the default one is working.
I have the same issue.
I am also having this issue as well, the only one that seems to be working is the default 🙃
Example of the problem:
I am also seeing the following, not sure if that is normal or part of this issue?:
Settings page:
OS: Windows 10 The version of Bootnote: Not sure how to pull this info but it asked me to update today.
I have the same issue.
This reason is that the file path is wrong.
FYI: I think that is due to the following two lines.
https://github.com/BoostIO/Boostnote/blob/d5d564f789fc7b59abf9f253102297f6cfaf363d/browser/main/lib/ConfigManager.js#L138
https://github.com/BoostIO/Boostnote/blob/d5d564f789fc7b59abf9f253102297f6cfaf363d/browser/main/lib/ConfigManager.js#L180
I think that this issue will be fixed if ../
will be removed.
Jep, same issue for me.
I can confirm... it's broken
It's Broken on my side too, exact same issues! Windows 10
Broken for me too. I messed with it for a bit today and was was able to get it working by making a small change to consts.js.
const themes = paths
.map(directory => fs.readdirSync(directory).map(file => {
const name = file.substring(0, file.lastIndexOf('.'))
return {
name,
path: path.join(directory.split(/\//g).slice(-3).join('/'), file),
className: `cm-s-${name}`
}
}))
Changed path to:
const themes = paths
.map(directory => fs.readdirSync(directory).map(file => {
const name = file.substring(0, file.lastIndexOf('.'))
return {
name,
path: path.join(CODEMIRROR_THEME_PATH, file),
className: `cm-s-${name}`
}
}))
This doesn't happen on Linux.
Broken for me too on Windows 10.
Got the same issue (also source code theme is not working):
On windows 10, I find it can be fixed in \boost\app-0.11.16\resources\app\compiled\main.js line 2823 change to "editorTheme.setAttribute('href', theme.path);"
Thanks Ljee - it worked for me.
However, I find it only works when I open boostnote. If I go to the preference and set the theme, it is invalid again.
However, I find it only works when I open boostnote. If I go to the preference and set the theme, it is invalid again.
Have the same. Themes stop working after first preferences save.
The same file, line 2867, change to "editorTheme.setAttribute('href', theme.path);" @GreaTDog, I think that might works.
The same file, line 2867, change to "editorTheme.setAttribute('href', theme.path);" @GreaTDog, I think that might works.
Preferences 'Save' button now seems to be unresponsive. But it saves settings - need to restart boostnotes app to see changes. However the app is usable now - thanks again.
I have same issue for me on Windows 10 since the new release
Fix in new release for Windows 7, on the advice of @bwarfson
Edit \boost\app-0.11.16\resources\app\compiled\main.js
Find :
var themes = paths.map(function (directory) {
return fs.readdirSync(directory).map(function (file) {
var name = file.substring(0, file.lastIndexOf('.'));
return {
name: name,
path: path.join(directory.split(/\//g).slice(-3).join('/'), file),
className: 'cm-s-' + name
};
});
}).reduce(function (accumulator, value) {
return accumulator.concat(value);
}, []).sort(function (a, b) {
return a.name.localeCompare(b.name);
});
Changed path to:
var themes = paths.map(function (directory) {
return fs.readdirSync(directory).map(function (file) {
var name = file.substring(0, file.lastIndexOf('.'));
return {
name: name,
path: path.join(CODEMIRROR_THEME_PATH, file),
className: 'cm-s-' + name
};
});
}).reduce(function (accumulator, value) {
return accumulator.concat(value);
}, []).sort(function (a, b) {
return a.name.localeCompare(b.name);
});
Same issue for me. It's affecting Boostnote on both PCs I use.
Same here on Windows 10 after installing the latest release.
This is a very bad bug.why not fix it.
On windows 10, I find it can be fixed in \boost\app-0.11.16\resources\app\compiled\main.js line 2823 change to "editorTheme.setAttribute('href', theme.path);"
Thanks Ljee - it worked for me.
This worked for me on windows 10. But the line was 2436 for release 11.17.
Fix in new release for Windows 7, on the advice of @bwarfson
Edit
\boost\app-0.11.16\resources\app\compiled\main.js
Find :
var themes = paths.map(function (directory) { return fs.readdirSync(directory).map(function (file) { var name = file.substring(0, file.lastIndexOf('.')); return { name: name, path: path.join(directory.split(/\//g).slice(-3).join('/'), file), className: 'cm-s-' + name }; }); }).reduce(function (accumulator, value) { return accumulator.concat(value); }, []).sort(function (a, b) { return a.name.localeCompare(b.name); });
Changed path to:
var themes = paths.map(function (directory) { return fs.readdirSync(directory).map(function (file) { var name = file.substring(0, file.lastIndexOf('.')); return { name: name, path: path.join(CODEMIRROR_THEME_PATH, file), className: 'cm-s-' + name }; }); }).reduce(function (accumulator, value) { return accumulator.concat(value); }, []).sort(function (a, b) { return a.name.localeCompare(b.name); });
Octen's solution worked for Boostnote version 11.16. When updated to ver 11.17, the fix no longer works sadly. I'm running on windows 10.
Fix in new release for Windows 7, on the advice of @bwarfson Edit
\boost\app-0.11.16\resources\app\compiled\main.js
Find :var themes = paths.map(function (directory) { return fs.readdirSync(directory).map(function (file) { var name = file.substring(0, file.lastIndexOf('.')); return { name: name, path: path.join(directory.split(/\//g).slice(-3).join('/'), file), className: 'cm-s-' + name }; }); }).reduce(function (accumulator, value) { return accumulator.concat(value); }, []).sort(function (a, b) { return a.name.localeCompare(b.name); });
Changed path to:
var themes = paths.map(function (directory) { return fs.readdirSync(directory).map(function (file) { var name = file.substring(0, file.lastIndexOf('.')); return { name: name, path: path.join(CODEMIRROR_THEME_PATH, file), className: 'cm-s-' + name }; }); }).reduce(function (accumulator, value) { return accumulator.concat(value); }, []).sort(function (a, b) { return a.name.localeCompare(b.name); });
Octen's solution worked for Boostnote version 11.16. When updated to ver 11.17, the fix no longer works sadly. I'm running on windows 10.
my version is 0.11.17 and Octen's solustion is still work for me. I'm running on windows 10 too.
Fix in new release for Windows 7, on the advice of @bwarfson Edit
\boost\app-0.11.16\resources\app\compiled\main.js
Find :var themes = paths.map(function (directory) { return fs.readdirSync(directory).map(function (file) { var name = file.substring(0, file.lastIndexOf('.')); return { name: name, path: path.join(directory.split(/\//g).slice(-3).join('/'), file), className: 'cm-s-' + name }; }); }).reduce(function (accumulator, value) { return accumulator.concat(value); }, []).sort(function (a, b) { return a.name.localeCompare(b.name); });
Changed path to:
var themes = paths.map(function (directory) { return fs.readdirSync(directory).map(function (file) { var name = file.substring(0, file.lastIndexOf('.')); return { name: name, path: path.join(CODEMIRROR_THEME_PATH, file), className: 'cm-s-' + name }; }); }).reduce(function (accumulator, value) { return accumulator.concat(value); }, []).sort(function (a, b) { return a.name.localeCompare(b.name); });
Octen's solution worked for Boostnote version 11.16. When updated to ver 11.17, the fix no longer works sadly. I'm running on windows 10.
my version is 0.11.17 and Octen's solustion is still work for me. I'm running on windows 10 too.
Worked for me also..!
Fix in new release for Windows 7, on the advice of @bwarfson Edit
\boost\app-0.11.16\resources\app\compiled\main.js
Find :var themes = paths.map(function (directory) { return fs.readdirSync(directory).map(function (file) { var name = file.substring(0, file.lastIndexOf('.')); return { name: name, path: path.join(directory.split(/\//g).slice(-3).join('/'), file), className: 'cm-s-' + name }; }); }).reduce(function (accumulator, value) { return accumulator.concat(value); }, []).sort(function (a, b) { return a.name.localeCompare(b.name); });
Changed path to:
var themes = paths.map(function (directory) { return fs.readdirSync(directory).map(function (file) { var name = file.substring(0, file.lastIndexOf('.')); return { name: name, path: path.join(CODEMIRROR_THEME_PATH, file), className: 'cm-s-' + name }; }); }).reduce(function (accumulator, value) { return accumulator.concat(value); }, []).sort(function (a, b) { return a.name.localeCompare(b.name); });
Octen's solution worked for Boostnote version 11.16. When updated to ver 11.17, the fix no longer works sadly. I'm running on windows 10.
my version is 0.11.17 and Octen's solustion is still work for me. I'm running on windows 10 too.
Worked for me also..!
Ah.... I tried Octen's solution again on my home windows 10 computer and it works... I probably just did something stupid on my work computer, like changing the file boost\app-0.11.16\resources\app\compiled\main.js
instead of boost\app-0.11.17\resources\app\compiled\main.js
. Sorry guys
Broken for me too. I messed with it for a bit today and was was able to get it working by making a small change to consts.js.
const themes = paths .map(directory => fs.readdirSync(directory).map(file => { const name = file.substring(0, file.lastIndexOf('.')) return { name, path: path.join(directory.split(/\//g).slice(-3).join('/'), file), className: `cm-s-${name}` } }))
Changed path to:
const themes = paths .map(directory => fs.readdirSync(directory).map(file => { const name = file.substring(0, file.lastIndexOf('.')) return { name, path: path.join(CODEMIRROR_THEME_PATH, file), className: `cm-s-${name}` } }))
I was unable to export file as html, this update worked for me as well. Note, path for version used was "C:\Users\zhumphrey\AppData\Local\boost\app-0.11.17\resources\app\compiled".
Boostnote version 11.16 updated to version 11.17 on Windows 10.
@boostio has funded $80.00 to this issue.
- Submit pull request via IssueHunt to receive this reward.
- Want to contribute? Chip in to this issue via IssueHunt.
- Checkout the IssueHunt Issue Explorer to see more funded issues.
- Need help from developers? Add your repository on IssueHunt to raise funds.
Changing the path as suggested also worked for me on win 10.
Should this be provided as a PR? Any reasons why this is not done yet?
@michaelw85 There's a PR for that (waiting to be merged): https://github.com/BoostIO/Boostnote/pull/3048
@ZeroX-DG Ok great! I overlooked the PR linked to this issue, it's somewhere in the middle of the thread 😅.
Great! Octen's Solution also worked for me. Thank u very much.@Octen Running Boostnote 0.11.17 on Windows 10.
Thanks, @Octen. Your fix worked for me (0.11.17, Win 10). This had been bothering me for at least a couple of weeks now.
@elliptic-shiho has funded $20.00 to this issue.
- Submit pull request via IssueHunt to receive this reward.
- Want to contribute? Chip in to this issue via IssueHunt.
- Checkout the IssueHunt Issue Explorer to see more funded issues.
- Need help from developers? Add your repository on IssueHunt to raise funds.
The fix for this #3048 has been merged and will be part of the next release 0.12.0
@rokt33r has rewarded $90.00 to @awolf81. See it on IssueHunt
- :moneybag: Total deposit: $100.00
- :tada: Repository reward(0%): $0.00
- :wrench: Service fee(10%): $10.00
Fund this Issue
Rewarded pull request
Click to copy link
Recent activities