The issue has been solved
Current behavior
Currently the image gallery only support images with https URL, however the native URL for Boostnote (:storage/xxx/xxx) does not work.
The only way to get it works for now is to use absolute path like file explorer
Related Issue: #2465
<!--
Let us know what is currently happening.
Please include some screenshots with the developer tools open (console tab) when you report a bug.
If your issue is regarding Boostnote mobile, please open an issue in the Boostnote Mobile repo š https://github.com/BoostIO/boostnote-mobile.
-->
Expected behavior
The expected behavior should be :storage style relative path should be work for Image Gallery
<!--
Let us know what you think should happen!
-->
Steps to reproduce
<!--
Please be thorough, issues we can reproduce are easier to fix!
-->
Environment
@daiyam Thanks for building this image gallery function, this is awesome. It would be great if it works for normal boostnote style URL. Otherwise the image URL could be easily broken when photos are moving around.
@noklam the issue seems to be with windows style URL :storage\xxx\xxx instead of :storage/xxx/xxx.
@daiyam You are correct. the back slash "" works fine though if it is a classic image
posted by ZeroX-DG about 6 years ago @ZeroX-DG I am not sure if they are the same problem. As noted I am using Boostnote 0.11.15 which include the bug fix from your reference issue already.
#2834 shows local images issue with "/" and "". As shown in my previous comment, "/" and "" works perfectly fine with local image, it only fails for Gallery. They are probably a related issue, but Gallery is quite a new feature so maybe the last fix #2834 did not take care of Gallery?
If possible please re-open this issue.
@ZeroX-DG Also please notice the 2nd image of the issue, even with "" the image render correctly if I use full path instead of :storage, I am using 0.11.15 already so this is a bug that have not been fixed.
@noklam I will try to make a fix this week-end
@daiyam Great, thank you! I just start to learn electron today, looking forward to seeing your fix. :grinning:
@boostio has funded $30.00 to this issue.
Sorry about the delay, I've forgotten to do the fix...
@daiyam looks like there is a fix implemented? Will this fix be merged soon?
@noklam sorry, I have no idea...
I have contacted Rokt33r about the PR containing the fix. With this I expect the fix to merged in the next few days. That also means that it will be part of the next release, which should be within a week.
posted by daiyam over 5 years ago This is fixed in the 0.12.0 release that you can download now! Thanks to #3027.
@rokt33r has rewarded $27.00 to @daiyam. See it on IssueHunt
- :moneybag: Total deposit: $30.00
- :tada: Repository reward(0%): $0.00
- :wrench: Service fee(10%): $3.00
IssueHunt