BoostIO/Boostnote

Do you want to work on this issue?

You can request for a bounty in order to promote it!

Text surrounded by asterisks in inline code blocks is wrongly highlighted #2251

chbndrhnns posted onGitHub

Current behavior

<img width="479" alt="screenshot 2018-07-27 12 51 44" src="https://user-images.githubusercontent.com/7534547/43317099-d49f946c-919b-11e8-8607-f26d9a150fb3.png">

When using asterisks in inline code blocks, the text between asterisks is highlighted like if it appeared in normal text blocks.

Expected behavior

Special formatting is not applied in inline code blocks

Steps to reproduce

  1. Go to edit mode
  2. Write ```
  • See local-only branches: git branch -vv | grep 'origin/.*: gone]' | awk '{print $1}'

Environment

  • Version : 0.11.8
  • OS Version and name : macOS 10.13.6

@boostio funded this issue with $30. Visit this issue on Issuehunt

posted by IssueHuntBot over 6 years ago

I cannot replicate it.


  • Version : 0.11.9.pre
  • OS Version and name: 16.04 Ubuntu
posted by modmod24 over 6 years ago

I forgot an important requirement: It only happens if the closing tag of an inline code block is on a new line like this:

- Delete branches that no longer exist remotely: `git remote prune origin
`

- See local-only branches: `git branch -vv | grep 'origin/.*: gone]' | awk '{print $1}'`

I am not sure if this is valid for inline code to be honest.

posted by chbndrhnns over 6 years ago

It's a problem with codemirror which don't like the closing ` on the new line.

The highlight in the editor show how the inline code block is detected. When in the preview, the result is fine.

screenshot

posted by daiyam about 6 years ago

Fund this Issue

$30.00
Funded
Only logged in users can fund an issue

Pull requests

Recent activities

boostio funded 30.00 for BoostIo/Boostnote# 2251
over 6 years ago