BoostIO/Boostnote

[BUG] PHP unexpected commented block code due to open tag #1908

Fowerld posted onGitHub

Current behavior

See below, I was writing quick (and dirty I know) notes over PHP password methods process:

capture1

Until I saw an unexpected commenting behavior from boostnote:

capture2

Expected behavior

  • No 'savage' commenting behavior.
  • Having back color syntax.

NB: this issue is not processing if I remove code style (after back ticks). Also I could reproduce this issue with another code style (ex: csharp) by leaving php open tag. Finally this issue is not processing if there's no php open tag, but of course there's no color syntax anymore.

Here's an example of expected behavior (using csharp color syntax):

capture3

Steps to reproduce

  1. Just write a php open tag in code block

Environment

  • Version : 0.11.4
  • OS Version and name : Windows 10.0.16299

NB: I've never had this issue with osx

Conclusion

I really love this tool, keep it working ! 👍


@kazup01 has boosted this issue with $20. Visit this issue on Issuehunt

posted by IssueHuntBot over 6 years ago

@Fowerld Would you please check with 0.11.5? Probably, my PR solved this problem.

posted by yosmoc over 6 years ago

@andrejims has started working. Visit this issue on Issuehunt

posted by IssueHuntBot over 6 years ago

@andrejims has stopped working. Visit this issue on Issuehunt

posted by IssueHuntBot over 6 years ago

@kazup01 has started working. Visit this issue on Issuehunt

posted by IssueHuntBot over 6 years ago

@kazup01 has stopped working. Visit this issue on Issuehunt

posted by IssueHuntBot over 6 years ago

@julianogouveia has started working. Visit this issue on Issuehunt

posted by IssueHuntBot over 6 years ago

This seems to be fine now, old ticket

posted by max-arias almost 5 years ago

Fund this Issue

$20.00
Funded

Pull requests

Recent activities

kazup01 funded 20.00 for BoostIo/Boostnote# 1908
over 6 years ago