BoostIO/BoostNote-App

Do you want to work on this issue?

You can request for a bounty in order to promote it!

Can't use ctrl-c to copy text in Vim binding mode #773

HineBlack posted onGitHub

Current behavior

<!-- Let us know what is currently happening. Please include some screenshots with the developer tools open (console tab) when you report a bug. If your issue is regarding the old Boostnote, please open an issue in the old repo 👉 https://github.com/BoostIO/Boostnote/issues. -->

I just switched from old Boostnote, and found I can's use ctrl+c to copy text into clipboard, which has been solved in old Boostnote issue #646.

Expected behavior

  1. Add a copy to clipboard to existing ctrl+c shortcut
  2. Change as to copy into clipboard on yank.
  3. Custom keybinding maybe, I personally prefer use Esc instead of ctrl+c to exit insert mode, in old Boostnote you can copy text with ctrl+c but it also exit insert mode, which is a little annoy for me.

Steps to reproduce

<!-- Please be thorough, issues we can reproduce are easier to fix! -->

  1. insert some text in Vim insert mode, select some text, try press ctrl-c to copy them into clipboard
  2. exit from vim insert mode, select some text, try press y to yank them, but it's not show in clipboard

Environment

Desktop/Web

  • Boost Note.next version: 0.12.4
  • OS version and name: Windows 10

The issue is still existing in Windows and Linux. It works fine in macOS since its copying shortcut is using Super(Cmd) + C instead of Ctrl + C.

How to fix

Just like the below link, adding an extra key should fix the issue.

https://github.com/BoostIO/Boostnote/pull/649/files#diff-7890cda3f01d76c730b641b51aca870a682d84971add9f45e9e22fc9cac46dc1R88-R93

Adding the code above to here should fix this issue.

posted by Rokt33r over 3 years ago

@Rokt33r

But does that mean that ctrl+c cannot really be used as an exit? Since some users might want to use this shortcut instead of escape.

I suppose it would be best to add a custom keymap for a copy so that users can use the default copy in VIM mode but also change it if they prefer exiting with that shortcut (or unset it).

I can easily add this to local space since it already has the implementation of keymaps, but for cloud, probably once it's ported? Or if we want the fix straight away, as suggested?

posted by Komediruzecki over 3 years ago

@boostio has funded $20.00 to this issue.


posted by issuehunt-app[bot] over 3 years ago

Fund this Issue

$20.00
Funded
Only logged in users can fund an issue

Pull requests

Recent activities

boostio funded 20.00 for BoostIO/BoostNote-App# 773
over 3 years ago