## Summary `spotbugs-maven-plugin:4.10.2.0:spotbugs` emits a warning during Maven site generation when the plugin has a non-JAR dependency, for example an XML artifact used as an exclude filter. The analysis itself works, but the report goal tries to read the XML artifact as a JAR while building the SpotBugs plugin URL mapping. ## Version - spotbugs-maven-plugin: 4.10.2.0 - Goal: `spotbugs` - Triggered via Maven site generation ## Reproducer Plugin configuration contains a non-JAR plugin dependency: ```xml com.github.spotbugs spotbugs-maven-plugin 4.10.2.0 com.example build-rules 1.0.0 spotbugs-exclude-filter xml ${settings.localRepository}/com/example/build-rules/1.0.0/build-rules-1.0.0-spotbugs-exclude-filter.xml ``` Run: ```bash mvn site ``` ## Actual behavior During site report generation: ```text [INFO] Generating "SpotBugs" report --- spotbugs-maven-plugin:4.10.2.0:spotbugs [WARNING] Failed to read SpotBugs plugin JAR for URL mapping: .../build-rules-1.0.0-spotbugs-exclude-filter.xml: zip END header not found ``` ## Expected behavior The report goal should ignore non-JAR plugin artifacts when building the bug type URL map, just as SpotBugs plugin detection already ignores files that do not end with `.jar`. ## Suspected cause `SpotBugsPluginsTrait.getSpotbugsPlugins()` appears to use `isSpotBugsPlugin(File file)`, which skips non-JAR files. However, `buildBugTypeUrlMap(...)` collects all `pluginArtifacts` without filtering for `.jar` files and then calls `new JarFile(pluginJar)` on each artifact. This causes XML plugin dependencies to be opened as JARs. ## Suggested fix Filter `pluginArtifacts` in `buildBugTypeUrlMap(...)` before attempting to open them with `JarFile`, for example: ```groovy if (artifact.file != null && artifact.file.exists() && artifact.file.name.endsWith('.jar')) { pluginJars << artifact.file } ``` or reuse a shared helper so non-JAR artifacts are skipped consistently. ## Notes This warning only appears during site/report generation. Normal SpotBugs checks are not affected.

Spotbugs report goal tries to read non-JAR plugin dependencies as JARs during site generation #1444

Company

Community

Support

Connect