sindresorhus/refined-github

Drop `view-markdown-source` feature #4834

iamandrewluca posted onGitHub

Please ensure:

  • The bug is caused by Refined GitHub. It doesn't happen if I disable the extension.

Description

GitHub announced native view-markdown-source that makes this feature duplicated if using refined-github

https://github.com/sindresorhus/refined-github/blob/main/source/features/view-markdown-source.tsx https://twitter.com/github/status/1443572280924147717

Screenshot

image

Console errors

No response

Example URL

https://github.com/sindresorhus/refined-github/blob/main/readme.md

Browser(s) used

Any


Did they add it to all?

() => pageDetect.isSingleFile() && /\.(mdx?|mkdn?|mdwn|mdown|markdown|litcoffee|rst)$/.test(location.pathname),

posted by yakov116 over 3 years ago
posted by iamandrewluca over 3 years ago

@yakov116 don't add the label to issues unless they're the only reference to it (which usually isn't the case), or else:

<img width="537" alt="Screen Shot 4" src="https://user-images.githubusercontent.com/1402241/135581322-ec276e56-f812-4660-8f56-801a8a1abe08.png">

In this specific case I'm not going to add the label to the PR either since the feature will still exist

Did they add it to all?

Good question! We occasionally drop features prematurely and then we realize they half-assed it, see this and #4833

posted by fregante over 3 years ago

Fund this Issue

$0.00
Funded

Pull requests