sindresorhus/refined-github

Do you want to work on this issue?

You can request for a bounty in order to promote it!

Refined GitHub has been loaded twice. #4827

RussKie posted onGitHub

Please ensure:

  • The bug is caused by Refined GitHub. It doesn't happen if I disable the extension.

Description

I haven't found an exact set of steps that leads to the message, but generally a combination of viewing all files in a PR on GitHub, viewing files for a specific commit result in the warning in the logs. Sometimes I get TypeError: Cannot read properties of undefined (reading 'cloneNode') error first, then after switching between tabs I eventually get the warning. Sometimes I get the warning straight away, followed by the error...

Screenshot

image

Console errors

VM52 refined-github.js:8646 
Uncaught TypeError: Cannot read properties of undefined (reading 'cloneNode')
    at add (VM52 refined-github.js:8646)
    at runAdd (VM52 refined-github.js:4602)
    at applyChanges (VM52 refined-github.js:4572)
    at SelectorObserver.addRootNodes (VM52 refined-github.js:4724)
    at Array.processBatchQueue (VM52 refined-github.js:4544)
    at MutationObserver.handleMutations (VM52 refined-github.js:4561)
add @ VM52 refined-github.js:8646
runAdd @ VM52 refined-github.js:4602
applyChanges @ VM52 refined-github.js:4572
addRootNodes @ VM52 refined-github.js:4724
processBatchQueue @ VM52 refined-github.js:4544
handleMutations @ VM52 refined-github.js:4561
setTimeout (async)
handleMutations @ VM52 refined-github.js:4563
attributes (async)
scheduleMacroTask @ VM52 refined-github.js:4555
(anonymous) @ VM52 refined-github.js:4548
SelectorObserver.observe @ VM52 refined-github.js:4761
observe @ VM52 refined-github.js:4781
init @ VM52 refined-github.js:8642
async function (async)
init @ VM52 refined-github.js:8631
runFeature @ VM52 refined-github.js:1964
setupPageLoad @ VM52 refined-github.js:1977
add @ VM52 refined-github.js:1999
async function (async)
add @ VM52 refined-github.js:1984
(anonymous) @ VM52 refined-github.js:8626
(anonymous) @ VM52 refined-github.js:9712
(anonymous) @ VM52 refined-github.js:9713

Example URL

https://github.com/dotnet/winforms/pull/5842/commits/d9fd5007c144dcaebe7314a4036cd0e0540e37e3

Browser(s) used

Edge, version 94.0.992.31 (Official build) (64-bit) Extension, v21.9.18


I've been seeing similar when opening a PR and then going to the Files Changed tab. Also when this happens I don't seem to get the quick review buttons. Refreshing the page fixes it.

posted by graemechapman over 3 years ago

Also when this happens I don't seem to get the quick review buttons. Refreshing the page fixes it.

That's #4702

posted by kidonng over 3 years ago

Fund this Issue

$0.00
Funded
Only logged in users can fund an issue

Pull requests