sindresorhus/refined-github

Do you want to work on this issue?

You can request for a bounty in order to promote it!

`comments-time-machine-links` breaks after review comments #4813

kidonng posted onGitHub

Please ensure:

  • The bug is caused by Refined GitHub. It doesn't happen if I disable the extension.

Description

It seems the solution commited in https://github.com/sindresorhus/refined-github/commit/b3cf351c1e1b4c975fe2370e470f3657c7551409 doesn't work anymore.

Also I think we should make the feature work on review comments instead of skipping them.

Screenshot

No response

Console errors

āŒ comments-time-machine-links 0.0.0 ā†’ TypeError: Cannot read properties of undefined (reading 'attributes')
    at init (refined-github.js:4829)
    at runFeature (refined-github.js:8013)
    at refined-github.js:15952
    at Set.forEach (<anonymous>)
    at HTMLElement.run (refined-github.js:15951)

Example URL

https://github.com/sindresorhus/refined-github/pull/1932#pullrequestreview-226419297

Browser(s) used

Chrome


Also I think we should make the feature work on review comments instead of skipping them.

šŸ‘

The hard part has basically been finding the comment time, because it's not always inside the comment element.

posted by fregante over 3 years ago

Fund this Issue

$0.00
Funded
Only logged in users can fund an issue

Pull requests