sindresorhus/refined-github

`quick-file-edit` conflicts with file icon extension (browser’s back button) #4788

BlueskyFR posted onGitHub

Please ensure:

  • The bug is caused by Refined GitHub. It doesn't happen if I disable the extension.

Description

Didn't know what to write in the title so please feel free to edit it :sweat_smile:

Using the Vivaldi browser, and refined Github, when going on a Github repo, then another page of the repo, then going back through the history, the icons on the left duplicate themselves. Please see the screenshots below.

Screenshot

Initial page: image

Then change branch: image

Then go back to the previous page (usually alt + left key on most browsers): image

We can clearly see the problem: image

Console errors

No response

Example URL

https://github.com/sindresorhus/refined-github

Browser(s) used

Vivaldi, cannot reproduce on Chromium


What icons extension are you using? That's not just Refined GitHub. It's also possible that the extension is adding the second icon because Refined GitHub is wrapping the previous icon in a <a>. Make sure you also open an issue on the icon extension repo.

posted by fregante over 3 years ago

What icons extension are you using?

That looks like https://github.com/homerchen19/github-file-icons. There is an issue regarding this: homerchen19/github-file-icons#85 but it seems to have been fixed last year. It could be something changed in GitHub but the extension hasn't update yet.

@BlueskyFR You can also try the one I'm using: https://github.com/Claudiohbsantos/github-material-icons-extension, it doesn't have issue with Refined GitHub.

It's also possible that the extension is adding the second icon because Refined GitHub is wrapping the previous icon in a <a>

Welp, I should have fixed that for every icon extension I find:

  • homerchen19/github-file-icons#82
  • dderevjanik/github-vscode-icons#27
  • lvarayut/github-file-icons#17
  • mallowigi/a-file-icon-idea#96
posted by kidonng over 3 years ago

Thanks for the work Kidong! We have had issues with them and usually I ask people to change to one that works.

posted by fregante over 3 years ago

Fund this Issue

$0.00
Funded

Pull requests