sindresorhus/refined-github

Rename "PR" references to "Pull Request" #4741

kidonng posted onGitHub

Description

While "PR" is easy to type and grasp for most people, it doesn't make much sense for casual users or newcomers to GitHub. I really like Refined GitHub works just like a native part of GitHub (and that's what makes it great), so I feel like "PR" is out of place and doesn't align with GitHub.

I propose to rename all visible "PR" references to "Pull Request" (case and plural may change). In README/internal code/comments we can probably keep using it.

Screenshot

image

Example URL

N/A


Hmmmmmmmm it might be ok if there's space for it, for clarity and consistency, otherwise PR is understandable enough, fast to read, and takes 1/6 of the space.

posted by fregante over 3 years ago

One feature that can be updated is comment-on-draft-pr-indicator

Screenshot

image


I think this can be a https://github.com/sindresorhus/refined-github/labels/good%20first%20issue for newer contributors.

If we want to fix this sooner, please assign me to it and I will do it.

posted by shinenelson over 3 years ago

That's the problem, that button is already pretty long. If we add 2 words to it will be long enough to almost stop looking like a button.

posted by fregante over 3 years ago

I think it looks okay, but I am not a UX expert, so I would not know for sure.

image

I feel that the 'PR' looks out of place especially when there is another button on the left that reads 'pull request'

posted by shinenelson over 3 years ago

Screenshot

image

The vast majority of those references are in comments

<img width="428" alt="Screen Shot" src="https://user-images.githubusercontent.com/1402241/132039589-69a20efb-c1a0-4ce6-9f2f-b941e6109228.png">

Feel free to open a PR with the few ones that are shown to the user, with screenshots of where they appear. I'll close this in the meanwhile.

I think Comment on draft pull request is too long since we'd be making the button 4 times longer.

posted by fregante over 3 years ago

Fund this Issue

$0.00
Funded

Pull requests