The issue has been closed
Please ensure:
Description
I have in my Refined GH CSS preferences:
* {
-moz-tab-size: 8 !important;
tab-size: 8 !important;
}
but this does not work because refined-github.css is prioritized above that, as seen in the inspector (screenshot attached.) Not sure if this is a straight up bug, or caused by interactions with another addon? Weirdly enough, the override for the background image size for the → arrow works fine… Background → image size override works due to !important
Refined GH Addon version: 21.8.22
Other addons installed:
- AdBlocker for YouTube™ 0.3.4
- cookies.txt 0.2
- Google search link fix 1.6.10
- GreaseMonkey 4.11
- OneTab 1.54
- Stylus 1.5.21
- uMatrix 1.4.4
Screenshot
Console errors
No response
Example URL
https://github.com/sindresorhus/refined-github/commit/b9dea1a78f79d4d8da129d3f2151892a655f0df9
Browser(s) used
Firefox 88.0.1
Just noticed, obviously the → size override works, the 4 wide one doesn't have !important on it and my changing it back to 8 does.
You can use :root * as the selector to override it.
However maybe we should still change the injection to use contentScript.register() instead. 🤔 Injection order is a bit difficult because every browser will handle it a little differently.
could also be a similar issue with affecting wide github css: https://github.com/xthexder/wide-github
the text should be all the way to the left side, but is not, as shown in the screenshot above.
should look like the screenshot below
You can use :root * as the selector to override it.
Ah, thanks for the hint. I started listing elements span, div, ... and had to keep adding more (e.g. td) as I found them…
However maybe we should still change the injection to use contentScript.register() instead. thinking Injection order is a bit difficult because every browser will handle it a little differently.
Any chance I could still convince you for a straight up "tab size" input box in the preferences? I've read #4289 and understand it's reasonably easy for people who know CSS, but looking around my own environment I think I'm the only one who knows how to do this. (C developer here, most of us don't know CSS and we really need our tab size at 8.)
(Yes that doesn't really have much to do with the actual issue here, I just finally took the time to look at what's going on. The tab size has been broken for quite some time on my end too, I just didn't have time to investigate.)
posted by fregante over 3 years ago
could also be a similar issue with affecting wide github css: xthexder/wide-github
You could ask them to improve their selector to override Refined GitHub’s:
Any chance I could still convince you for a straight up "tab size" input box in the preferences?
No chance because there's an extension for that already: chrome.google.com/webstore/detail/tab-size-on-github/ofjbgncegkdemndciafljngjbdpfmbkn?hl=en
Well, I mean, I really just want Refined GH to leave it alone at the default 8 wide Tabs :stuck_out_tongue_winking_eye:
(To be perfectly honest I'm not sure why the Tab size, which is a personal preference that is likely to differ among users, is mixed inbetween the features that Refined GH provides — and without even the off switch that some actual features have.) ← This is just me speaking my mind, not intending any ill will or offense.
But, yeah, pasting some CSS does the trick too [… hopefully with fewer hoops to jump through if this ordering issue can be fixed somehow.] Don't really need an extension.
I understand your confusion, but 8 spaces is a bad default and until today I never heard anyone using it or preferring it, whether as a tab or spaces, that's why it's part of the refinements that this extension includes by default.
I'll close this issue since there's a solution. I'll open a more specific issue for the CSS injection order.
Edit: https://github.com/sindresorhus/refined-github/issues/4731
until today I never heard anyone using it or preferring it
Just in case you're wondering: the entire field of C systems & embedded development, including the Linux and BSD kernels and much of the low-level system environment uses 8-wide Tabs. Which doesn't mean that people agree it's a good level of indentation, just that if someone wants to use 4 or 2 (both common values), they use spaces instead. (Probably because the "4-wide people" and "2-wide people" would otherwise be annoyed with each other when things don't line up.)
specific issue for the CSS injection order
Indeed this is why I'm here, although I hadn't realized yet that it might affect everything. Thanks for looking at it! I hope it can be worked out, and thanks for the workaround too, I'll keep that in for the meantime :smiley:.
IssueHunt