⚠️ Many features don't work until you refresh the page #4695

Seeing this as well.

Trying to run bisect to find the issue doesn't work, https://github.com/sindresorhus/refined-github/blob/d8cadc830723728ab5c32f36cea31ea3f6aee814/source/helpers/bisect.tsx#L54 document.body is somehow null.

highlight-deleted-and-added-files-in-diffs is breaking due to https://github.com/sindresorhus/refined-github/blob/d8cadc830723728ab5c32f36cea31ea3f6aee814/source/features/highlight-deleted-and-added-files-in-diffs.tsx#L43 trying to call cloneNode on undefined.

Sometimes refreshing the page can get it to work. May try to look into this sometime this week as I'm really missing these features.

Dug around for a bit, this is due to deduplicate not being set to has-rgh-inner on some features after https://github.com/sindresorhus/refined-github/pull/4571.

e.g. if I apply the following patch, faster-reviews now starts functioning properly even after multiple tab clicks.

diff --git a/source/features/faster-reviews.tsx b/source/features/faster-reviews.tsx
index 1b11bd54..7cc4e23c 100644
--- a/source/features/faster-reviews.tsx
+++ b/source/features/faster-reviews.tsx
@@ -54,6 +54,7 @@ void features.add(__filebasename, {
                },
        ],
        awaitDomReady: false,
+       deduplicate: 'has-rgh-inner',
        init: addSidebarReviewButton,
 }, {
        shortcuts: {
@@ -63,5 +64,6 @@ void features.add(__filebasename, {
                pageDetect.isPRFiles,
        ],
        awaitDomReady: false,
+       deduplicate: 'has-rgh-inner',
        init: initReviewButtonEnhancements,
 });

I may spend some time this weekend identifying where all this needs to be updated, if no one gets to it before then.

Thank you! It's possible that they just changed the container for PRs so it broke it for every PR feature.

It'd be great to create a map of "page:deduplicate-selector" so that this can be handled by the feature manager instead of having to manually specify it in every feature, but this might take a little effort. It's best to focus on patching the specific features first so we can release a fix soon.

Anyway this is what I mean:

``` js const deduplicateMap = { isPR: '.has-rgh-inner', isDashboard: '.has-rgh', }

@williammck would you be able to send a PR?

This has been fixed for many PR-related features and will be in the upcoming v21.10.1.

If you still see this problem after updating, please leave a link to the page you're seeing the issue on (i.e. the page you have to refresh for features to appear)