`linkify-code` is broken for code blocks in markdown #4688

fregante posted onGitHub

Please ensure:

The bug is caused by Refined GitHub. It doesn't happen if I disable the extension.

Description

This used to be linkified:

// https://github.com/fregante

<a href="https://github.com/fregante">

URLs in actual code are still linkified, both embedded and when visiting the isSingleFile page

https://github.com/sindresorhus/refined-github/blob/9036cceec3455f275a5bd3cca8064d73309195dd/readme.md#L15-L17

Screenshot

Console errors

None

Browser(s) used

safari

🤦 Oops, I forgot about vanilia code block in #4613 and removed .comment-body selector. That example was missing from the issue I took test URLs from, so I missed it as well.

But as I said in that PR, the way GitHub constructs markup is not so friendly to mod. We need to think some better ways.

posted by kidonng over 3 years ago

A future PR should also include this link in a javascript comment because it contains more context:

https://github.com/sindresorhus/refined-github/pull/4710#discussion_r694896008

posted by fregante over 3 years ago

Fund this Issue

$0.00

Funded

Only logged in users can fund an issue

Pull requests

Do you want to work on this issue?

`linkify-code` is broken for code blocks in markdown #4688

Please ensure:

Description

Screenshot

Console errors

Browser(s) used

Company

Community

Support

Connect