`restore-file` occasionally restores the wrong commit #4679

fregante posted onGitHub

The bug is caused by Refined GitHub. It doesn't happen if I disable the extension.

Rare occurrence but:

Now you'll have a PR with the changes that the force-push made.

You'll notice that the feature "succeeds" but the commits are empty. This is a live example: 419c37c (#4677)

Safari

Maybe it's not even due to force pushes. There were no force pushes in https://github.com/npmhub/npmhub/pull/141, but this "Restore" commit is incorrect: 7485182 (#141)

The issue specifically is that it "correctly" fetched the file from the base branch (main), but GitHub still shows the file as a "change" in the PR (even though when merged nothing will actually change): https://github.com/npmhub/npmhub/pull/141/files#diff-719f723e7f36f1f0192a75b8750569dcb1319113ea7e038109894895d2ea7d74

You can try restoring the same file multiple times but that's what you get.

In short, I think we should fetch the file not from the base branch but from the base commit.

I think the repro is:

posted by fregante over 3 years ago

Fund this Issue

$0.00

Funded

Only logged in users can fund an issue

Pull requests