sindresorhus/refined-github

Extend `sticky-sidebar` to other places #4664

shinenelson posted onGitHub

Description

GitHub has revamped the organization profile pages to look consistent with the overall layout of the rest of the website.

It now has a sidebar that could possibly be made sticky with sticky-sidebar.

I made a quick attempt to evaluate whether this could be a small enough change to pursue even with the summer feature freeze.

But it was not directly obvious to me for 2 reasons :

  1. The selector used to select the sidebar uses a ternary operator https://github.com/sindresorhus/refined-github/blob/fd71c473b92cc2597590f89b1e3aba22832837e9/source/features/sticky-sidebar.tsx#L11 which would mean a non-trivial effort in adding a new selector.
  2. isOrganizationProfile from github-url-detection is a document-based detection

I could make an effort at this if it is okay to during the feature freeze.

Screenshot

image

Example URL

https://github.com/tc39


EDIT : from https://github.com/sindresorhus/refined-github/issues/4144#issuecomment-902142687, this feature could be extended to wiki table of contents too.


The content of the sidebar doesn't seem to be particularly useful to spend any time on it, even from a "consistency" standpoint.

posted by fregante over 3 years ago

The selector used to select the sidebar uses a ternary operator

This needs to be rewritten anyway, cf. https://github.com/sindresorhus/refined-github/pull/4522#discussion_r660576801

posted by cheap-glitch over 3 years ago

Fund this Issue

$0.00
Funded

Pull requests