sindresorhus/refined-github

`git-checkout-pr` is broken #4661

fregante posted onGitHub

Please ensure:

  • The bug is caused by Refined GitHub. It doesn't happen if I disable the extension.

Description

<img width="426" alt="Screen Shot 11" src="https://user-images.githubusercontent.com/1402241/129320364-ad9ef70c-98a5-4ee3-a7e3-f33ddaedbe94.png">

Console errors

It appears when clicking the Code dropdown

Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'select_dom('[action="/users/checkout-preference"]', dropdown).closest')

Example URL

https://github.com/sindresorhus/refined-github/pull/4650

Browser(s) used

safari


In my case there's not even tabs in the dropdown anymore: image

posted by cheap-glitch over 3 years ago

The good part is that this should now just be part of the main/local tab, so it should work regardless of tabs.

posted by fregante over 3 years ago

EDIT: as of 21.8.22, the issue seems to have been fully fixed.

In my case there's not even tabs in the dropdown anymore:

Did you have Codespaces enabled? Because I have and I see this error when opening the dropdown:

Uncaught (in promise) TypeError: Cannot read property 'defaultProps' of undefined
    at create (refined-github.js:3531)
    at Object.h [as createElement] (refined-github.js:3563)
    at checkoutOption (refined-github.js:7868)
    at HTMLHtmlElement.handleMenuOpening (refined-github.js:7895)
    at HTMLHtmlElement.listenerFn (refined-github.js:3365)

@fregante Please reopen, this still doesn't work if one have "Codespaces" tab enabled.

posted by kidonng over 3 years ago

Fund this Issue

$0.00
Funded

Pull requests