sindresorhus/refined-github

`clean-pinned-issues` contains vertically misaligned elements in Chrome #4598

4086606 posted onGitHub

Please ensure:

  • The bug is caused by Refined GitHub. It doesn't happen if I disable the extension.

Description

Text and icons in clean-pinned-issues appears misaligned and uses the table display mode for no discernable reason.

This issue occurs over 700px and makes the feature quite annoying to use.

Screenshot

<img alt="github com_microsoft_vscode_issues_q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc" src="https://user-images.githubusercontent.com/82655227/126564310-2fad4029-39d1-43b9-9c5d-ccab682db99d.png" height="450"/>

Console errors

No response

Example URL

https://github.com/sindresorhus/refined-github/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc

Browser(s) used

Chrome 91.0.4472.124


posted by busches over 3 years ago

Can you post what it looks like on this repo since we have multiple lines? I see that the text is slightly lower, but it might just be attributable to the font and I don’t know if it can be fixed across-systems. What OS are you using? Can you check which font is being picked exactly for that text? The devtools should only show one font.

posted by fregante over 3 years ago

In fact you can see that the text in the Labels | Milestones buttons are also slightly misaligned, but it's less evident because there isn't so much lowercase text in it.

I think your best bet would probably be to remove some padding-top with a custom style. We can leave this issue open in case other see the same and have alternative solutions that work everywhere.

posted by fregante over 3 years ago

I believe it's using display: table but that's not really as versatile as flexbox which would do this easily across browsers

posted by 4086606 over 3 years ago

You can see the same misalignment in the buttons I mentioned, which are plain inline-block.

As for flex vs table, you can find the reason why it was chosen in the original PR (I think it was because it just required less code). I don’t think flex would solve the issue, but if you can do that without altering the padding explicitly then sure 👍

posted by fregante over 3 years ago

Alignment padding definitely does work differently between Firefox and Chrome, caused me a lot of grief in my UI bootcamp days

posted by 4086606 over 3 years ago

One liner fix

posted by 4086606 over 3 years ago

Fund this Issue

$0.00
Funded

Pull requests