The issue has been closed

`sticky-sidebar` seems to not be working #4587

stdedos posted onGitHub

Please ensure:

The bug is caused by Refined GitHub. It doesn't happen if I disable the extension.

Describe the problem and how to replicate it

See visual

Screenshots/video/gif showing the issue, if it’s visual

Screenshot_2021-07-19_21-57-38

Console errors, if any

21:58:34.981 3203:118 GET https://github.githubassets.com/assets/optimizely-fa3539d3.js net::ERR_BLOCKED_BY_CLIENT
21:58:35.468 collector.githubapp.com/github/page_view?dimensions[page]=https%3A%2F%2Fgithub.com%2FXpra-org%2Fxpra%2Fissues%2F3203&dimensions[title]=xpra%20top%20client%20renders%20garbage%20%C2%B7%20Issue%20%233203%20%C2%B7%20Xpra-org%2Fxpra&dimensions[referrer]=&dimensions[user_agent]=Mozilla%2F5.0%20(Windows%20NT%2010.0%3B%20Win64%3B%20x64)%20AppleWebKit%2F537.36%20(KHTML%2C%20like%20Gecko)%20Chrome%2F89.0.0.0%20Safari%2F537.36&dimensions[screen_resolution]=2560x1440&dimensions[pixel_ratio]=1&dimensions[browser_resolution]=2560x1297&dimensions[tz_seconds]=10800&dimensions[timestamp]=1626721115465&&dimensions[request_id]=CD09%3A1FA3%3A371A57%3A38D1CC%3A60F5CB53&dimensions[visitor_id]=1358881981391334425&dimensions[region_edge]=fra&dimensions[region_render]=iad&dimensions[user_id]=77430244&dimensions[user_login]=Xpra-org&dimensions[repository_id]=331941572&dimensions[repository_nwo]=Xpra-org%2Fxpra&dimensions[repository_public]=true&dimensions[repository_is_fork]=false&dimensions[repository_network_root_id]=331941572&dimensions[repository_network_root_nwo]=Xpra-org%2Fxpra&&measures[performance_timing]=1-1-1-1250-1137-1041-987-595-1-1-1--1250-0---22-683-583--592-591&&dimensions[actor_id]=133706&dimensions[actor_login]=stdedos&dimensions[actor_hash]=d3a7c4869a9576681ee315fc31a823c5269441c18bb6780e2dc7f1d720f5dc9a&dimensions[cid]=316389366.1619160089:1 GET https://collector.githubapp.com/github/page_view?dimensions[page]=https%3A%2F%2Fgithub.com%2FXpra-org%2Fxpra%2Fissues%2F3203&dimensions[title]=xpra%20top%20client%20renders%20garbage%20%C2%B7%20Issue%20%233203%20%C2%B7%20Xpra-org%2Fxpra&dimensions[referrer]=&dimensions[user_agent]=Mozilla%2F5.0%20(Windows%20NT%2010.0%3B%20Win64%3B%20x64)%20AppleWebKit%2F537.36%20(KHTML%2C%20like%20Gecko)%20Chrome%2F89.0.0.0%20Safari%2F537.36&dimensions[screen_resolution]=2560x1440&dimensions[pixel_ratio]=1&dimensions[browser_resolution]=2560x1297&dimensions[tz_seconds]=10800&dimensions[timestamp]=1626721115465&&dimensions[request_id]=CD09%3A1FA3%3A371A57%3A38D1CC%3A60F5CB53&dimensions[visitor_id]=1358881981391334425&dimensions[region_edge]=fra&dimensions[region_render]=iad&dimensions[user_id]=77430244&dimensions[user_login]=Xpra-org&dimensions[repository_id]=331941572&dimensions[repository_nwo]=Xpra-org%2Fxpra&dimensions[repository_public]=true&dimensions[repository_is_fork]=false&dimensions[repository_network_root_id]=331941572&dimensions[repository_network_root_nwo]=Xpra-org%2Fxpra&&measures[performance_timing]=1-1-1-1250-1137-1041-987-595-1-1-1--1250-0---22-683-583--592-591&&dimensions[actor_id]=133706&dimensions[actor_login]=stdedos&dimensions[actor_hash]=d3a7c4869a9576681ee315fc31a823c5269441c18bb6780e2dc7f1d720f5dc9a&dimensions[cid]=316389366.1619160089 net::ERR_BLOCKED_BY_CLIENT
Image (async)
recordPageView @ collector-api.ts:150
applyCall @ collector-api.ts:436
push @ collector-api.ts:212
(anonymous) @ octolytics-pageview.ts:7
async function (async)
(anonymous) @ octolytics-pageview.ts:2
execute @ octolytics-pageview.ts:2
(anonymous) @ system-lite.js:20
Promise.then (async)
register @ system-lite.js:19
(anonymous) @ behaviors-3687fddf.js:1
21:58:35.488 stats.ts:42 POST https://api.github.com/_private/browser/stats net::ERR_BLOCKED_BY_CLIENT
Q @ stats.ts:42
requestIdleCallback (async)
(anonymous) @ stats.ts:23
async function (async)
(anonymous) @ stats.ts:20
Y @ stats.ts:14
Qr @ timing-stats.ts:26
(anonymous) @ web-vitals.js:1
o @ web-vitals.js:1
(anonymous) @ web-vitals.js:1
execute @ timing-stats.ts:51
(anonymous) @ system-lite.js:20
Promise.then (async)
register @ system-lite.js:19
(anonymous) @ behaviors-3687fddf.js:1
21:58:35.957 stats.ts:42 POST https://api.github.com/_private/browser/stats net::ERR_BLOCKED_BY_CLIENT
Q @ stats.ts:42
requestIdleCallback (async)
(anonymous) @ stats.ts:23
async function (async)
(anonymous) @ stats.ts:20
Y @ stats.ts:14
(anonymous) @ report-long-tasks.ts:6
21:58:38.043 stats.ts:42 POST https://api.github.com/_private/browser/stats net::ERR_BLOCKED_BY_CLIENT
Q @ stats.ts:42
requestIdleCallback (async)
(anonymous) @ stats.ts:23
async function (async)
(anonymous) @ stats.ts:20
Y @ stats.ts:14
(anonymous) @ report-long-tasks.ts:6

Example URL

https://github.com/Xpra-org/xpra/issues/3203

Browser(s) used

Chrome v89

#4567

posted by yakov116 over 3 years ago

Okay ... but the issue is closed, so ...?

I am on 21.6.8, and there seems to be 21.7.18, but I cannot update somehow (?!?)

posted by stdedos over 3 years ago

I am not saying its a duplicate, its just the same issue

posted by yakov116 over 3 years ago

What is the gif demonstrating? I see a sticky sidebar in it

posted by fregante over 3 years ago

Your gif iamge also shows the header bar to be sticky. I assumed they worked together?

Or sticky header was a GH/RG feature, but no more?

posted by stdedos over 3 years ago

~~@fregante go to pull requests, go to issues, open an issue you will see it does not work~~ hmm now it is for me 🤷

posted by yakov116 over 3 years ago

@yakov116 I have an idea: do you happen to use https://github.com/yourduskquibbles/webannoyances?

It seems that it interferes with something

posted by stdedos over 3 years ago

posted by yakov116 over 3 years ago

However, even after my workaround, the Repo Root https://github.com/yourduskquibbles/webannoyances is still broken for me

posted by stdedos over 3 years ago

Now its doing it again. @fregante can you try on repo root?

posted by yakov116 over 3 years ago

That's the sticky header, not the sidebar. The sticky header is native to GitHub. This is a GitHub issue 😃

posted by fregante over 3 years ago

Actually it's not even a bug if you're using that extension. The first line literally says:

Block annoying web elements such as sticky headers,

posted by fregante over 3 years ago

However, even after my workaround,

ie I disabled it...

the Repo Root https://github.com/yourduskquibbles/webannoyances is still broken for me

...

posted by stdedos over 3 years ago

the Repo Root yourduskquibbles/webannoyances is still broken for me

...

Missed this! Indeed sticky-sidebar appears to not work on repo roots

posted by fregante over 3 years ago

Indeed sticky-sidebar appears to not work on repo roots

It seems to work fine on https://github.com/fregante/Awesome-WebExtensions

Am I missing something here?

posted by shinenelson over 3 years ago

It's been 25d since @fregante re-verified my claim of repo-roots being broken.

I don't remember seeing any improvement, and there seems not to have this ticket auto-closed (correctly).

Unfortunately, I am on vacation and I couldn't help you 😕

posted by stdedos over 3 years ago

Thanks for checking @shinenelson! Indeed it's working for me now.

I do see the sidebar occasionally not working on issues, but it's probably best to open a new specific issue if we find how to reproduce that.

posted by fregante over 3 years ago

Fund this Issue

$0.00

Funded

Pull requests

`sticky-sidebar` seems to not be working #4587

Please ensure:

Describe the problem and how to replicate it

Screenshots/video/gif showing the issue, if it’s visual

Console errors, if any

Example URL

Browser(s) used

Company

Community

Support

Connect