sindresorhus/refined-github

Do you want to work on this issue?

You can request for a bounty in order to promote it!

"Issues" and "Bugs" tabs are not highlighted when navigating to them #4579

cheap-glitch posted onGitHub

Please ensure:

  • The bug is caused by Refined GitHub. It doesn't happen if I disable the extension.

Describe the problem and how to replicate it

Go to https://github.com/sindresorhus/refined-github and click on the "Issues" or "Bugs" tab. The tab name will not be underlined in orange like it should. (Also the pinned issues will be displayed on the "Bugs" tab). Reloading the page makes this bug go away.

This is likely caused by the change in PJAX navigation also causing #4567 — but this can't be fixed with just a deduplicate.

Screenshots/video/gif showing the issue, if it’s visual

image

Console errors, if any

No response

Example URL

https://github.com/sindresorhus/refined-github

Browser(s) used

Firefox 90.0


Indeed this is tricky because it’s not replaced during the page change, but it depends on the page content.

I can think of 2 solutions:

  • try to have GitHub’s own code to highlight it like it does with the others
  • have a secondary init with deduplicate:false (probably) that only updates its state
posted by fregante over 3 years ago

Fund this Issue

$0.00
Funded
Only logged in users can fund an issue

Pull requests