Add indicator for last commit that was code reviewed #4573

GitHub already does this:

<img width="948" alt="Screen Shot" src="https://user-images.githubusercontent.com/1402241/126030948-0962dac5-b265-4842-a3cf-9aaf7ee4ba66.png">

I think the OP is talking about doing something similar on the "Commits" tab of a PR page.

Yeah, GitHub does this, but the general PR view often gets cluttered up with comments and other history entries apart from commits, so it would be great to have it on the "Commits" tab of a PR page like @cheap-glitch said.

I see. Determining this "last review" time and actually displaying it accurately is difficult, especially if there's a force push. Examples:

• do we use the "last viewed" date like in my screenshot to match GitHub’s behavior? Then we need to probably fetch the whole Conversation tab page and hope to find it
• do we just keep the "last opened" time locally? Then cross-browser/cross-device reviews are lost
• do we just use the last review’s time? This is the most reasonable

In most cases we also need to fetch the full commit list and their dates.

If we can avoid the time/commit match, maybe we just need to store/fetch the last commit seen and then find it on the list. This would partially fix the "force push" problem because if the commit no longer exists, no indicator is added.

Any other implementation suggestions?

Probably saving a timestamp for the time when a user submits a code review makes most sense. Then you know everything > timestamp is unseen.

But as mentioned that doesn’t cover 2 situations:

• reviews from other devices/browsers
• force pushes

Yeah true, no knowledge about the implementation details of this repo so don't know what options there are.

Closing as too fickle/complex, I suggest asking GitHub