sindresorhus/refined-github

`remove-unused-repo-tabs` doesn't move tabs into "more" if `more-dropdown` is disabled #4562

ouuan posted onGitHub

Please ensure:

  • The bug is caused by Refined GitHub. It doesn't happen if I disable the extension.

Describe the problem and how to replicate it

  1. Enable remove-unused-repo-tabs and disable more-dropdown.
  2. Go to a repo that you can't edit and has unused tabs.
  3. The unused repo tabs disappears instead of being moved to "more".

My suggestion

  1. Add a feature that moves "security" and "insights" to the dropdown menu.
  2. Add another feature that adds "Compare", "Dependencies", "Commits" and "Branches" in the dropdown menu.
  3. Make more-dropdown not a "feature", so that any feature can use it, and if there are any features using it, the dropdown menu appears.

BTW, in the current issue form, there's no section like "Anything elses?" or "Your suggestions", so I don't know where to properly provide my suggestions.

Screenshots/video/gif showing the issue, if it’s visual

img

Console errors, if any

No response

Example URL

https://github.com/trustwallet/assets

Browser(s) used

Firefox 89.0.2


These are all good suggestions. Here are some more (some conflicting) suggestions:

  • renamed remove-unused-repo-tabs to clean-repo-tabs and include moving Insights and Security as the same feature
  • hide these tabs via hidden property instead of removing them altogether, if it works. This way each tab could be unhidden via CSS and we don’t need to granularize clean-repo-tabs
posted by fregante over 3 years ago

Big đź‘Ť

  • hide these tabs via hidden property instead of removing them altogether, if it works. This way each tab could be unhidden via CSS and we don’t need to granularize clean-repo-tabs

Only if it does not require too much work

posted by yakov116 over 3 years ago

Only if it does not require too much work

I think it won't require much work, but it might conflict with GitHub’s "responsive nav" logic because it's index-based.

posted by fregante over 3 years ago

Fund this Issue

$0.00
Funded

Pull requests