sindresorhus/refined-github

Disable "Comment" button when there is no text in gist.github.com #4550

Yash-Singh1 posted onGitHub

<!-- 1. Make sure your requested feature makes sense for Refined GitHub: https://github.com/sindresorhus/refined-github/issues/2960 2. Include a REAL URL where the feature should appear. e.g. Do you want a feature to appear on the main page of a repo? Paste a link to a repo -->

You can comment on any gist, here is one: https://gist.github.com/tterb/982ae14a9307b80117dbf49f624ce0e8.

When trying to comment and the comment is blank, the comment button is not marked as disabled. However, in the main GitHub UI, the "Comment" button is disabled when the comment is blank.

Current:

Screenshot from 2021-07-08 20-40-25

Desired:

Screenshot from 2021-07-08 20-48-36

Here is the steps:

  • Add disabled attribute
  • Add disabled class
  • Set the aria-disabled property to true

I mean… it’s right, but we’re not going to add code to handle this non-issue.

posted by fregante over 3 years ago

Fund this Issue

$0.00
Funded

Pull requests