sindresorhus/refined-github

Do you want to work on this issue?

You can request for a bounty in order to promote it!

`table-input` and `collapsible-content-button` don't appear on some review forms #4542

fregante posted onGitHub

Also the upload button resurfaced by minimize-upload-bar is not showing.

  1. Open any PR, like https://github.com/sindresorhus/refined-github/pull/4507
  2. Start a review
  3. Try to comment on the same thread

They appear when starting on a new thread, but not when continuing on an existing thread.

<img width="802" alt="Screen Shot 15" src="https://user-images.githubusercontent.com/1402241/124642779-6f72a600-deba-11eb-99ac-2716b2c5c9c0.png">


It seems this happens because the textarea and its associated toolbar don't exist on page load, they're first created when adding the review comment. Reloading the page makes this bug go away.
The same thing happens with resolved review threads since they're lazy-loaded.

Using the additional onNewComments listener fixes it for resolved threads but not for new review comments. Should the listener be extended to cover this, or should we rely on some kind of observer instead?

Also the upload button resurfaced by minimize-upload-bar is not showing

The button is missing, this seems to be a GitHub bug.

posted by cheap-glitch over 3 years ago

they're first created when adding the review comment

By who? Are they loaded together with the comment itself as a partial? Do you see any events that we can use in GitHub’s code? onNewComments seems unrelated (and as you mention it doesn't catch all cases) and selector-observer feels heavy, especially on a page that tends to get huge and already has trash performance on long PRs (especially on Safari)

We could potentially use onElementRemoval to track a submission and then look for the new form when that promise resolve, but this seem very fickle.

posted by fregante over 3 years ago

Fund this Issue

$0.00
Funded
Only logged in users can fund an issue

Pull requests