IssueHunt
Bug Bounty (New!)
Browse
Sign in with GitHub
sindresorhus/refined-github

Do you want to work on this issue?

You can request for a bounty in order to promote it!

`user-local-time` breaks positioning of some hovercards #4527

cheap-glitch posted onGitHub

<!-- Thanks for reporting a bug! ⛰ Make sure the bug is caused by Refined GitHub. Try disabling the extension first. Show us the bug and help us replicate it, include: 1. A REAL URL where the bug appears. If it happens on a private repo, find an equivalent public URL. 2. A screenshot/video/gif of the issue, if it’s visual. 3. Any related errors in the browser’s console, if any. -->

Go to https://github.com/sindresorhus/refined-github and hover on the contributors avatars:

image

This is caused by the CSS added in https://github.com/sindresorhus/refined-github/pull/4384. The weird thing is that it happens on some hovercards but not all. I don't know if it's the "Sponsor" button or the "Committed to this repo" notice which makes this bug appear (or both).

The solution should probably be to reserve the space via CSS like we do for the tag changelog link feature. This way we don't change the height of the hovercard after it's loaded

posted by fregante over 3 years ago

The solution should probably be to reserve the space via CSS

This is what https://github.com/sindresorhus/refined-github/pull/4384/files did, but while it fixed the cropping bug it also created this new one.

Edit: the cropping issue is back… image

Maybe the positioning itself should be fixed, but only if the card contains certain elements (that might be loaded asynchronously) like a sponsor button or "Collaborator" infos.

posted by cheap-glitch over 3 years ago

Fund this Issue

$0.00
Funded
Only logged in users can fund an issue

Pull requests

Company
AboutMission
Community
SpectrumEmbed
Support
FAQTerms of usePrivacy policyCode of conductCredits
Connect
FacebookTwitter

© 2019 BoostIO, Inc.