sindresorhus/refined-github

move 'delete fork' button #4518

shinenelson posted onGitHub

This is an idea that popped into my head when I was jumping between an upstream repository and my fork.

forked-to adds a an extra element sandwiched between the 'Fork' button and the fork count. But quick-repo-deletion adds an extra button to the beginning of the button group.

The question / idea that I am trying to point to here is : Can we possibly merge the positions of these 2 features?

The obvious advantage in doing this is the saving of space and not be thrown random number of buttons on different pages ( I am already annoyed with the 'Sponsor' button that comes and goes on different repositories ). I would expect a consistent number of buttons for my UX that does not take my focus as I move about different pages ( I am also kind of extra observant on such small UX changes ).

I think it is rare that people would have multiple forks of the same repository in more than one place. The most common scenario is to have only 1 fork per repository.

In that scenario, both these features are mutually exclusive. The button that opens the fork can be replaced with a button the deletes the fork ( :x: as the icon ).

In the other scenario where there are multiple forks and the dropdown is to be displayed, we could probably prepend the :x: button before the dropdown ( But it could cause some kind of confusion though ).

I am not sure whether this would be too complicated in terms of checking both of the features. Whether either of them are disabled by the user, etc. That is why I am opening this issue as a discussion rather than a feature request.


Can you edit the dom in your browser and take a screenshot to see what it would look like? It kind of makes sense but I’m afraid it wouldn’t be as clear if it’s merged into that Fork button, it would look like this I suppose:

Fork | Delete fork | 123

posted by fregante almost 4 years ago

in the first scenario ( which is the majority, in my opinion ) where there is only one fork and no drop-down menu, it would look something like :

Screenshot 2021-06-26 at 10-50-47 move 'delete fork' button · Issue #4518 · sindresorhus refined-github

in the other scenario, where there are multiple forks and the drop-down is always displayed :

Screenshot 2021-06-26 at 10-49-12 move 'delete fork' button · Issue #4518 · sindresorhus refined-github

PS : I used :x: as the icon because I could paste the emoji ( and that is what I suggested in the description of the issue ). Ideally, we should use the trash bucket octicon.

posted by shinenelson almost 4 years ago

I’m afraid it wouldn’t be as clear if it’s merged into that Fork button

The risk of clicking the button? I think that the enlarging warning button and the red-ish hue overlay over the whole page is warning enough.

We could possibly increase the timeout to 10 seconds though. I have always felt the 5 second timeout is too short for slow pokes like me.

posted by shinenelson almost 4 years ago

I think it's best where it is. Such change would mean adding the button exactly where the fork button is, so the user might click on it by mistake.

posted by fregante over 3 years ago

Fund this Issue

$0.00
Funded

Pull requests