The issue has been closed

`shorten-links` feature hides markdown images which are part of a link. #4505

egormanga posted onGitHub

Example page: https://github.com/egormanga/egormanga/blob/3a6c21f809660a9f8bda63a72e2c2c339860f9ec/README.md

<details> <summary>Before:</summary>

</details>

<details> <summary>After:</summary>

</details>

Example of markup causing the issue:

<th>
    <a href=...>
        <img src=...>   <!-- will disappear -->
        <p>Text</p>
    </a>
</th>

Heh, indeed, we use textContent to check whether it’s a customized link. We need to add a !link.firstElementChild check, probably on my shorten-repo-url package

posted by fregante almost 4 years ago

@fregante Hello! Hoped to work on this as my first contribution. I had a problem while load unpacking the extension and loading it through web-ext as well. It said - Could not load background script 'build/browser-polyfill.js'

I noticed the browser-polyfill.js and background.js were missing from the build folder but were mentioned in the manifest.json file. Am I missing out on a step somewhere?

posted by saarahasad over 3 years ago

Yes you'll also have to run npm run watch to generate those files while you develop.

However, as I specified in my previous comment, the change needs to be done in the package that takes care of the replacement: https://github.com/fregante/shorten-repo-url

posted by fregante over 3 years ago

@fregante I've made the necessary change and created a pull request. I checked if it works fine for the general use case using the URLs mentioned here https://github.com/fregante/shorten-repo-url/blob/main/test.js :)

posted by saarahasad over 3 years ago

Fund this Issue

$0.00

Funded

Pull requests

`shorten-links` feature hides markdown images which are part of a link. #4505

Company

Community

Support

Connect