The issue has been closed

This is something we can prevent in the future, for every feature, inside features/index: isUserProfile.length === 0 && awaitDomReady === false
-> throw Error
The length check means that the function is DOM-based; it would have to be repeated for each function in the include
array.
posted by fregante almost 4 years ago
But there are domReady safe detections (Those in meta tags).
I was thinking of allowing elementReady pageDetections (With no plan of how to implement)
posted by yakov116 almost 4 years ago
But there are domReady safe detections (Those in meta tags).
Good point
I was thinking of allowing elementReady pageDetections (With no plan of how to implement)
This would mean copying the detections from GitHub-url-detection
and replacing exists()
with elementReady
, I suppose, but I don't think I'd like that (because we have to update the selector in 2 places)
posted by fregante almost 4 years ago