Add support for labels other than "bug" in `bugs-tab` #4452

Duplicate of #2897

Another point to take into account is currently logical operators do not work (label:bug OR label::bug: Bug). So any other labels would require a brand new query for every repo.

Duplicate of #2897

Oh, should've checked first 😆

Another point to take into account is currently logical operators do not work (label:bug OR label:🐛 Bug). So any other labels would require a brand new query for every repo.

Darn, that's a hard one.

Also, in regards to your regexp, labels like not-a-bug would also match :|

Yeah, that's awful 😭

We could add support either for a specific set of labels by adding another query inside the existing call. This way regular repos just get a single call while customized repos will get 2 calls

Example:

    const {search, labels} = await api.v4(`
        search(type: ISSUE, query: "label:${cache.get('bugs-label') ?? 'bugs'} is:open is:issue repo:${getRepo()!.nameWithOwner}") {
            issueCount
        }
        labels: repository() {label /*get labels somehow*/}
    `);

    if (search.issueCount > 0) {
        return search.issueCount;
    }

    const bugsLabel = labels.find(/* bugs label */)
    if (bugsLabel) {
        await cache.set('bugs-label', bugsLabel);
        return countBugs() // Recursive
    }

    return 0

And extra checks to avoid infinite recursion. The example is pseudo-code, can be improved in lots of ways.

I feel like we may be biting ourselves in the back. I think there is no end to this. Imagine if a repo has "severe bug" and "minor bug" etc. Which one do we take? If we take one of them we will get complaints that "you showing the wrong bug label".

I feel like we may be biting ourselves in the back

True, we do risk getting requests for new labels occasionally, but since there have only ever been 2 requests for custom bug labels I think we'll be fine.

As for "the wrong label," that's why I suggested using a predefined list instead of using /bug/i to guess the label. We can see what the common big repos are using and add those to our list. We can decide which label makes the cut later on.

If anyone wants to do this, the following is the query

    labels(query: "bug", first: 10) {
      nodes {
        name
      }
    }

Anyone have sample repo's I can test on. So far I have 🐛 Bug and confirmed-bug.

AND.... https://github.blog/changelog/2021-08-02-search-issues-by-label-using-logical-or